mambax7/xoopsheadline

View on GitHub

Showing 53 of 59 total issues

Function renderBlock has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    public function renderBlock(bool $force_update = false): bool
    {
        $retval = false;
        if ($force_update || $this->headline->cacheExpired()) {
            if (!$this->updateCache()) {
Severity: Minor
Found in class/HeadlineRenderer.php - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function recurseCopy has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    public static function recurseCopy(string $src, string $dst): void
    {
        $dir = \opendir($src);
        //        @mkdir($dst);
        if (!@\mkdir($dst) && !\is_dir($dst)) {
Severity: Minor
Found in class/Common/FilesManagement.php - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method setOrder has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function setOrder(string $bid, string $title, string $weight, string $visible, string $side, string $bcachetime, ?array $bmodule = null): void
Severity: Major
Found in class/Common/Blocksadmin.php - About 50 mins to fix

    Avoid deeply nested control flow statements.
    Open

                                if (is_file($templateFolder . $v)) {
                                    unlink($templateFolder . $v);
                                }
    Severity: Major
    Found in include/onupdate.php - About 45 mins to fix

      Consider simplifying this complex logical expression.
      Open

                  if ($oldtitle[$i] !== $title[$i]
                      || $oldweight[$i] !== $weight[$i]
                      || $oldvisible[$i] !== $visible[$i]
                      || $oldside[$i] !== $side[$i]
                      || $oldbcachetime[$i] !== $bcachetime[$i]
      Severity: Major
      Found in class/Common/Blocksadmin.php - About 40 mins to fix

        Method truncateHtml has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                string $text,
                ?int $length = 100,
                string $ending = '...',
                bool $exact = false,
                bool $considerHtml = true
        Severity: Minor
        Found in class/Common/SysUtility.php - About 35 mins to fix

          Function _parse has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function &_parse(): bool
              {
                  $retval = true;
                  if (!isset($this->parser)) {
                      require_once XOOPS_ROOT_PATH . '/class/xml/rss/xmlrss2parser.php';
          Severity: Minor
          Found in class/HeadlineRenderer.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getEditor has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              public static function getEditor(?\Xmf\Module\Helper $helper = null, ?array $options = null): ?\XoopsFormTextArea
              {
                  $descEditor = null;
          
                  /** @var Helper $helper */
          Severity: Minor
          Found in class/Common/SysUtility.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getErrors has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              public function &getErrors(bool $ashtml = true)
              {
                  if ($ashtml) {
                      $retval = '';
                      if (\count($this->errors) > 0) {
          Severity: Minor
          Found in class/HeadlineRenderer.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function renameColumns has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              private function renameColumns(): void
              {
                  $tables = new Tables();
                  foreach ($this->renameColumns as $table) {
                      $tableName   = $table['tablename'];
          Severity: Minor
          Found in class/Common/Migrate.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function loadSampleData has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          function loadSampleData(): void
          {
              global $xoopsConfig;
              $moduleDirName      = \basename(\dirname(__DIR__));
              $moduleDirNameUpper = \mb_strtoupper($moduleDirName);
          Severity: Minor
          Found in testdata/index.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function xoops_module_uninstall_xoopsheadline has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          function xoops_module_uninstall_xoopsheadline(\XoopsModule $module): bool
          {
              //    return true;
          
              $moduleDirName      = \basename(\dirname(__DIR__));
          Severity: Minor
          Found in include/onuninstall.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function xoops_module_install_xoopsheadline has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          function xoops_module_install_xoopsheadline(\XoopsModule $module): bool
          {
              require_once \dirname(__DIR__, 3) . '/mainfile.php';
          
              $moduleDirName = \basename(\dirname(__DIR__));
          Severity: Minor
          Found in include/oninstall.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language