mangroveorg/datawinners

View on GitHub
datawinners/media/javascript/JSON_fix/json_parse.js

Summary

Maintainability
F
4 days
Test Coverage

Function json_parse has a Cognitive Complexity of 89 (exceeds 5 allowed). Consider refactoring.
Open

var json_parse = (function () {
    "use strict";

// This is a function that can parse a JSON text, producing a JavaScript
// data structure. It is a simple, recursive descent parser. It does not use
Severity: Minor
Found in datawinners/media/javascript/JSON_fix/json_parse.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function json_parse has 222 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var json_parse = (function () {
    "use strict";

// This is a function that can parse a JSON text, producing a JavaScript
// data structure. It is a simple, recursive descent parser. It does not use
Severity: Major
Found in datawinners/media/javascript/JSON_fix/json_parse.js - About 1 day to fix

    Function number has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            number = function () {
    
    // Parse a number value.
    
                var number,
    Severity: Minor
    Found in datawinners/media/javascript/JSON_fix/json_parse.js - About 1 hr to fix

      Function string has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              string = function () {
      
      // Parse a string value.
      
                  var hex,
      Severity: Minor
      Found in datawinners/media/javascript/JSON_fix/json_parse.js - About 1 hr to fix

        Function object has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                object = function () {
        
        // Parse an object value.
        
                    var key,
        Severity: Minor
        Found in datawinners/media/javascript/JSON_fix/json_parse.js - About 1 hr to fix

          Avoid deeply nested control flow statements.
          Open

                                      for (i = 0; i < 4; i += 1) {
                                          hex = parseInt(next(), 16);
                                          if (!isFinite(hex)) {
                                              break;
                                          }
          Severity: Major
          Found in datawinners/media/javascript/JSON_fix/json_parse.js - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                    } else if (typeof escapee[ch] === 'string') {
                                        string += escapee[ch];
                                    } else {
                                        break;
                                    }
            Severity: Major
            Found in datawinners/media/javascript/JSON_fix/json_parse.js - About 45 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      return typeof reviver === 'function' ? (function walk(holder, key) {
                          var k, v, value = holder[key];
                          if (value && typeof value === 'object') {
                              for (k in value) {
                                  if (Object.prototype.hasOwnProperty.call(value, k)) {
              Severity: Major
              Found in datawinners/media/javascript/JSON_fix/json_parse.js and 1 other location - About 6 hrs to fix
              datawinners/media/javascript/JSON_fix/json_parse_state.js on lines 380..395

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 168.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status