Sign upLogin

mangroveorg/datawinners

View on GitHub
Star
datawinners/media/javascript/entity/datasender_actions.js

Summary

Maintainability
D
2 days
Test Coverage

File datasender_actions.js has 466 lines of code (exceeds 250 allowed). Consider refactoring.
Open

function warnThenDeleteDialogBox(allIds, all_selected, entity_type, action_element) {
    var delete_dialog = $("#delete_ds_block");
    delete_dialog.data("allIds", allIds);
    delete_dialog.data("all_selected", all_selected);
    delete_dialog.data("entity_type", entity_type);
Severity: Minor
Found in datawinners/media/javascript/entity/datasender_actions.js - About 7 hrs to fix

    Function init_dialog_box_for_web_users has 82 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function init_dialog_box_for_web_users() {
    var markup = "<tr><td>${short_name}</td><td>${name}</td><td style='width:150px;'>" +
        "${location}</td><td>" +
        "<input type='text' style='width:150px' class='ds-email ${hideInput}' ${input_field_disabled}/>" +
        "<label style='font-weight:inherit'>${email}</label>" +
    Severity: Major
    Found in datawinners/media/javascript/entity/datasender_actions.js - About 3 hrs to fix

      Function DataSenderActionHandler has 57 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      DW.DataSenderActionHandler = function () {

    init_dialog_box_for_web_users();
    init_warnThenDeleteDialogBox();
    init_add_remove_from_project();
      Severity: Major
      Found in datawinners/media/javascript/entity/datasender_actions.js - About 2 hrs to fix

        Function init_add_remove_from_project has 49 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function init_add_remove_from_project() {
    var all_project_block = $("#all_project_block").dialog({
        autoOpen: false,
        modal: true,
        title: gettext('Add to Questionnaires'),
        Severity: Minor
        Found in datawinners/media/javascript/entity/datasender_actions.js - About 1 hr to fix

          Function init_warnThenDeleteDialogBox has 41 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function init_warnThenDeleteDialogBox() {
    var delete_dialog = $("#delete_ds_block").dialog({
            title: gettext("Warning!"),
            modal: true,
            autoOpen: false,
          Severity: Minor
          Found in datawinners/media/javascript/entity/datasender_actions.js - About 1 hr to fix

            Function populate_dialog_box_for_web_users has 29 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function populate_dialog_box_for_web_users(table, all_selected) {
    if (all_selected) {
        var total_records = table.fnSettings().fnRecordsDisplay();
        var current_page_size = $(table).find("input.row_checkbox:checked").length;
        $("#all_selected_message").show();
            Severity: Minor
            Found in datawinners/media/javascript/entity/datasender_actions.js - About 1 hr to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                              if (response.success) {
                    var table = $("#datasender_table").dataTable();
                    table.fnSettings()._iDisplayStart = delete_dialog.data("pageToGo");
                    table.fnReloadAjax();
                }
              Severity: Major
              Found in datawinners/media/javascript/entity/datasender_actions.js and 1 other location - About 1 hr to fix
              datawinners/media/javascript/subjects/subject_actions.js on lines 42..46

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 65.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 4 locations. Consider refactoring.
              Open

                          $.blockUI({ message: '<h1><img src="/media/images/ajax-loader.gif"/><span class="loading">'
                + gettext("Just a moment") + '...</span></h1>', css: { width: '275px', zIndex: 1000000}});
              Severity: Major
              Found in datawinners/media/javascript/entity/datasender_actions.js and 3 other locations - About 30 mins to fix
              datawinners/media/javascript/entity/datasender_actions.js on lines 322..323
              datawinners/media/javascript/project/sms_tester.js on lines 20..20
              datawinners/media/javascript/datawinners.js on lines 2..2

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 45.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 4 locations. Consider refactoring.
              Open

                      $.blockUI({ message: '<h1><img src="/media/images/ajax-loader.gif"/><span class="loading">'
            + gettext("Just a moment") + '...</span></h1>', css: { width: '275px', zIndex: 1000000}});
              Severity: Major
              Found in datawinners/media/javascript/entity/datasender_actions.js and 3 other locations - About 30 mins to fix
              datawinners/media/javascript/entity/datasender_actions.js on lines 150..151
              datawinners/media/javascript/project/sms_tester.js on lines 20..20
              datawinners/media/javascript/datawinners.js on lines 2..2

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 45.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status