Sign upLogin

mangroveorg/datawinners

View on GitHub
Star
datawinners/media/javascript/entity/send_sms.js

Summary

Maintainability
F
4 days
Test Coverage

Function SmsViewModel has 301 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function SmsViewModel(){
  var self = this;

  var smsTextArea = $("#sms-text");
Severity: Major
Found in datawinners/media/javascript/entity/send_sms.js - About 1 day to fix

    Function SmsViewModel has a Cognitive Complexity of 50 (exceeds 5 allowed). Consider refactoring.
    Open

    function SmsViewModel(){
  var self = this;

  var smsTextArea = $("#sms-text");
    Severity: Minor
    Found in datawinners/media/javascript/entity/send_sms.js - About 7 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File send_sms.js has 303 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    function SmsViewModel(){
  var self = this;

  var smsTextArea = $("#sms-text");
    Severity: Minor
    Found in datawinners/media/javascript/entity/send_sms.js - About 3 hrs to fix

      Function sendSms has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        self.sendSms = function(project_id){
      var project_id_type = typeof project_id;
      if (project_id_type != 'string') {
          project_id = "";
      }
      Severity: Minor
      Found in datawinners/media/javascript/entity/send_sms.js - About 1 hr to fix

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

          self.validateGroupSelection = function(){

    if(self.selectedSmsOption() == 'group' && self.selectedGroupNames().length == 0){
        self.selectedGroupNames.setError(gettext("This field is required."));
        return false;
        Severity: Major
        Found in datawinners/media/javascript/entity/send_sms.js and 2 other locations - About 3 hrs to fix
        datawinners/media/javascript/entity/send_sms.js on lines 247..258
        datawinners/media/javascript/entity/send_sms.js on lines 261..272

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 96.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

          self.validateMyPollRecipientsSelection = function(){

    if(self.selectedSmsOption() == 'poll_recipients' && self.selectedMyPollRecipientsNames().length == 0){
        self.selectedMyPollRecipientsNames.setError(gettext("This field is required."));
        return false;
        Severity: Major
        Found in datawinners/media/javascript/entity/send_sms.js and 2 other locations - About 3 hrs to fix
        datawinners/media/javascript/entity/send_sms.js on lines 247..258
        datawinners/media/javascript/entity/send_sms.js on lines 274..285

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 96.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

          self.validateQuestionnaireSelection = function(){

    if(self.selectedSmsOption() == 'linked' && self.selectedQuestionnaireNames().length == 0){
        self.selectedQuestionnaireNames.setError(gettext("This field is required."));
        return false;
        Severity: Major
        Found in datawinners/media/javascript/entity/send_sms.js and 2 other locations - About 3 hrs to fix
        datawinners/media/javascript/entity/send_sms.js on lines 261..272
        datawinners/media/javascript/entity/send_sms.js on lines 274..285

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 96.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          self.smsOptionList = ko.observableArray([ {"label":gettext('Select Recipients'), disable: ko.observable(true)},
                                            {"label":gettext('Group'), "code": "group"},
                                            {"label":gettext('Contacts linked to a Questionnaire'), "code": "linked"},
                                            {"label":gettext('Other People'), "code": "others"}]);
        Severity: Major
        Found in datawinners/media/javascript/entity/send_sms.js and 1 other location - About 2 hrs to fix
        datawinners/media/javascript/project/poll_options.js on lines 36..41

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 83.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status