Sign upLogin

mangroveorg/datawinners

View on GitHub
Star
datawinners/media/javascript/file_uploader/fileuploader.js

Summary

Maintainability
F
4 days
Test Coverage

File fileuploader.js has 853 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * http://github.com/valums/file-uploader
 * 
 * Multiple file upload component with progress-bar, drag-and-drop. 
 * © 2010 Andrew Valums ( andrew(at)valums.com )
Severity: Major
Found in datawinners/media/javascript/file_uploader/fileuploader.js - About 2 days to fix

    Function obj2url has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
    Open

    qq.obj2url = function(obj, temp, prefixDone){
    var uristrings = [],
        prefix = '&',
        add = function(nextObj, i){
            var nextTemp = temp
    Severity: Minor
    Found in datawinners/media/javascript/file_uploader/fileuploader.js - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _createInput has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        _createInput: function(){                
        var input = document.createElement("input");
        
        if (this._options.multiple){
            input.setAttribute("multiple", "multiple");
    Severity: Minor
    Found in datawinners/media/javascript/file_uploader/fileuploader.js - About 1 hr to fix

      Function FileUploader has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      qq.FileUploader = function(o){
    // call parent constructor
    qq.FileUploaderBasic.apply(this, arguments);
    
    // additional options
      Severity: Minor
      Found in datawinners/media/javascript/file_uploader/fileuploader.js - About 1 hr to fix

        Function obj2url has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        qq.obj2url = function(obj, temp, prefixDone){
    var uristrings = [],
        prefix = '&',
        add = function(nextObj, i){
            var nextTemp = temp
        Severity: Minor
        Found in datawinners/media/javascript/file_uploader/fileuploader.js - About 1 hr to fix

          Function _setupDragDrop has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              _setupDragDrop: function(){
        var self = this,
            dropArea = this._find(this._element, 'drop');                        

        var dz = new qq.UploadDropZone({
          Severity: Minor
          Found in datawinners/media/javascript/file_uploader/fileuploader.js - About 1 hr to fix

            Function FileUploaderBasic has 32 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            qq.FileUploaderBasic = function(o){
    this._options = {
        // set to true to see the server response
        debug: false,
        action: '/server/upload',
            Severity: Minor
            Found in datawinners/media/javascript/file_uploader/fileuploader.js - About 1 hr to fix

              Function _attachEvents has 28 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  _attachEvents: function(){
        var self = this;              
                  
        qq.attach(self._element, 'dragover', function(e){
            if (!self._isValidFileDrag(e)) return;
              Severity: Minor
              Found in datawinners/media/javascript/file_uploader/fileuploader.js - About 1 hr to fix

                Function _validateFile has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                Open

                    _validateFile: function(file){
        var name, size;
        
        if (file.value){
            // it is a file input
                Severity: Minor
                Found in datawinners/media/javascript/file_uploader/fileuploader.js - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function _upload has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    _upload: function(id, params){
        var file = this._files[id],
            name = this.getName(id),
            size = this.getSize(id);
                Severity: Minor
                Found in datawinners/media/javascript/file_uploader/fileuploader.js - About 1 hr to fix

                  Function indexOf has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                  qq.indexOf = function(arr, elt, from){
    if (arr.indexOf) return arr.indexOf(elt, from);
    
    from = from || 0;
    var len = arr.length;
                  Severity: Minor
                  Found in datawinners/media/javascript/file_uploader/fileuploader.js - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Avoid too many return statements within this function.
                  Open

                          return true;
                  Severity: Major
                  Found in datawinners/media/javascript/file_uploader/fileuploader.js - About 30 mins to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                    qq.detach = function(element, type, fn){
    if (element.removeEventListener){
        element.removeEventListener(type, fn, false);
    } else if (element.attachEvent){
        element.detachEvent('on' + type, fn);
                    Severity: Major
                    Found in datawinners/media/javascript/file_uploader/fileuploader.js and 1 other location - About 1 hr to fix
                    datawinners/media/javascript/file_uploader/fileuploader.js on lines 53..59

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 70.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                    qq.attach = function(element, type, fn){
    if (element.addEventListener){
        element.addEventListener(type, fn, false);
    } else if (element.attachEvent){
        element.attachEvent('on' + type, fn);
                    Severity: Major
                    Found in datawinners/media/javascript/file_uploader/fileuploader.js and 1 other location - About 1 hr to fix
                    datawinners/media/javascript/file_uploader/fileuploader.js on lines 60..66

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 70.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status