Sign upLogin

marano/bgirlz

View on GitHub
Star
spec_helper.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method upload_page_and_assert_data_was_saved has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

def upload_page_and_assert_data_was_saved(params, success = true)
  visit '/'
  fill_in 'name', :with => params[:name] if params[:name]
  fill_in 'middle_initial', :with => params[:middle_initial] if params[:middle_initial]
  fill_in 'last_name', :with => params[:last_name] if params[:last_name]
Severity: Minor
Found in spec_helper.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method upload_page_and_assert_data_was_saved has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

def upload_page_and_assert_data_was_saved(params, success = true)
  visit '/'
  fill_in 'name', :with => params[:name] if params[:name]
  fill_in 'middle_initial', :with => params[:middle_initial] if params[:middle_initial]
  fill_in 'last_name', :with => params[:last_name] if params[:last_name]
Severity: Minor
Found in spec_helper.rb - About 1 hr to fix

    There are no issues that match your filters.

    Category
    Status