Sign upLogin

maratori/async

View on GitHub
Star

Showing 4 of 4 total issues

Method Executor.validateAndGetMethodInfo has 57 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (e *Executor) validateAndGetMethodInfo(
    jobName string,
    receiver reflect.Type,
    method reflect.Type,
) (methodInfo, error) {
Severity: Minor
Found in async.go - About 1 hr to fix

    Method Executor.validateAndGetMethodInfo has 8 return statements (exceeds 4 allowed).
    Open

    func (e *Executor) validateAndGetMethodInfo(
    jobName string,
    receiver reflect.Type,
    method reflect.Type,
) (methodInfo, error) {
    Severity: Major
    Found in async.go - About 50 mins to fix

      Method Executor.Prepare has 6 return statements (exceeds 4 allowed).
      Open

      func (e *Executor) Prepare(method interface{}, args ...interface{}) (string, json.RawMessage, error) {
    methodType := reflect.TypeOf(method)
    if methodType.Kind() != reflect.Func {
        return "", nil, errors.Errorf("func expected, received %s", methodType)
    }
      Severity: Major
      Found in async.go - About 40 mins to fix

        Method Executor.Register has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
        Open

        func (e *Executor) Register( //nolint:gocognit // TODO: simplify
    jobName string,
    receiver interface{},
    method interface{},
) (func(context.Context, json.RawMessage) error, error) {
        Severity: Minor
        Found in async.go - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language