Sign upLogin

marcells/node-build-monitor

View on GitHub
Star
app/services/CircleCI.js

Summary

Maintainability
D
2 days
Test Coverage

Function exports has 201 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function() {
  var self = this,
    requestBuilds = function (callback) {
      const {
        vcs,
Severity: Major
Found in app/services/CircleCI.js - About 1 day to fix

    Function exports has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
    Open

    module.exports = function() {
  var self = this,
    requestBuilds = function (callback) {
      const {
        vcs,
    Severity: Minor
    Found in app/services/CircleCI.js - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function requestBuilds has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        requestBuilds = function (callback) {
      const {
        vcs,
        username,
        project,
    Severity: Minor
    Found in app/services/CircleCI.js - About 1 hr to fix

      Function configure has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        self.configure = function(config) {
    self.configuration = config;

    if (!self.configuration.vcs) {
      console.error(`[CircleCI] Please configure the [vcs] parameter`);
      Severity: Minor
      Found in app/services/CircleCI.js - About 1 hr to fix

        Function formatWorkflow has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            formatWorkflow = function (buildsGroup) {
      const { vcs, username, project } = self.configuration;

      if (buildsGroup.some(build => build.in_workflow=== false)) {
        return buildsGroup.map(build => self.formatBuild(build));
        Severity: Minor
        Found in app/services/CircleCI.js - About 1 hr to fix

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

              if (typeof self.configuration.caPath !== "undefined") {
      request = request.defaults({
        agentOptions: {
          ca: require("fs")
            .readFileSync(self.configuration.caPath)
          Severity: Major
          Found in app/services/CircleCI.js and 3 other locations - About 2 hrs to fix
          app/services/Drone.js on lines 131..140
          app/services/GitLab.js on lines 228..234
          app/services/Travis.js on lines 78..84

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 83.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status