Sign upLogin

marcells/node-build-monitor

View on GitHub
Star

Showing 159 of 159 total issues

Function VSTSRestBuilds has a Cognitive Complexity of 73 (exceeds 5 allowed). Consider refactoring.
Open

function VSTSRestBuilds() {
  let basicAuth = null;
  let url = null;
  let project = null;
  let collection = null;
Severity: Minor
Found in app/services/Tfs.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function exports has a Cognitive Complexity of 70 (exceeds 5 allowed). Consider refactoring.
Open

module.exports = function () {
    var self = this,
        requestWithDefaults,
        flatten = function (arrayOfArray) {
            return [].concat.apply([], arrayOfArray);
Severity: Minor
Found in app/services/Jenkins.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function exports has a Cognitive Complexity of 65 (exceeds 5 allowed). Consider refactoring.
Open

module.exports = function () {
    var self = this,
        flatten = function(arrayOfArray) {
            return [].concat.apply([], arrayOfArray);
        },
Severity: Minor
Found in app/services/GitLab.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function VSTSRestBuilds has 236 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function VSTSRestBuilds() {
  let basicAuth = null;
  let url = null;
  let project = null;
  let collection = null;
Severity: Major
Found in app/services/Tfs.js - About 1 day to fix

    Function exports has 225 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    module.exports = function () {
    var self = this,
        flatten = function(arrayOfArray) {
            return [].concat.apply([], arrayOfArray);
        },
    Severity: Major
    Found in app/services/GitLab.js - About 1 day to fix

      Function exports has a Cognitive Complexity of 56 (exceeds 5 allowed). Consider refactoring.
      Open

      module.exports = function () {
    var self = this,
        selectMany = function (array, selector) {
            return array.map(selector).reduce(function (x, y) { return x.concat(y); }, []);
        },
      Severity: Minor
      Found in app/services/TeamCity.js - About 1 day to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function TfsRestRelease has a Cognitive Complexity of 53 (exceeds 5 allowed). Consider refactoring.
      Open

      function TfsRestRelease() {
  let basicAuth = null;
  let instance = null;
  let project = null;
  let protocol = null;
      Severity: Minor
      Found in app/services/TfsRelease.js - About 1 day to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function exports has 201 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      module.exports = function() {
  var self = this,
    requestBuilds = function (callback) {
      const {
        vcs,
      Severity: Major
      Found in app/services/CircleCI.js - About 1 day to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            self.configure = function (config) {
        self.configuration = config;

        if (config.username && config.password) {
            var protocol = config.url.match(/(^|\s)(https?:\/\/)/i);
        Severity: Major
        Found in app/services/BambooDeploy.js and 1 other location - About 6 hrs to fix
        app/services/Bamboo.js on lines 119..131

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 173.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            self.configure = function (config) {
        self.configuration = config;

        if (config.username && config.password) {
            var protocol = config.url.match(/(^|\s)(https?:\/\/)/i);
        Severity: Major
        Found in app/services/Bamboo.js and 1 other location - About 6 hrs to fix
        app/services/BambooDeploy.js on lines 113..125

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 173.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function exports has 162 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        module.exports = function () {
    var self = this,
        selectMany = function (array, selector) {
            return array.map(selector).reduce(function (x, y) { return x.concat(y); }, []);
        },
        Severity: Major
        Found in app/services/TeamCity.js - About 6 hrs to fix

          Function TfsRestRelease has 159 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function TfsRestRelease() {
  let basicAuth = null;
  let instance = null;
  let project = null;
  let protocol = null;
          Severity: Major
          Found in app/services/TfsRelease.js - About 6 hrs to fix

            Function exports has a Cognitive Complexity of 41 (exceeds 5 allowed). Consider refactoring.
            Open

            module.exports = function () {
    var self = this,
    queryBuilds = function (callback) {
        requestBuilds(function (error, body) {
            if (error) {
            Severity: Minor
            Found in app/services/Bamboo.js - About 6 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function exports has 156 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            module.exports = function () {
    var self = this,
        getRequestHeaders = function () { // build request header
            if (typeof process.env.BUILDBUDDY_ACCESS_TOKEN !== 'undefined') {
                self.configuration.access_token = process.env.BUILDBUDDY_ACCESS_TOKEN;
            Severity: Major
            Found in app/services/BuddyBuild.js - About 6 hrs to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      getBuildStatus = function(data) {
            if (data.statusid === status.ok) {
                return 'Green';
            }
            else if (data.statusid === status.error) {
              Severity: Major
              Found in app/services/PRTG.js and 1 other location - About 6 hrs to fix
              app/services/PRTG.js on lines 85..107

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 155.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      getBuildStatusText = function(data) {
            if (data.statusid === status.ok) {
                return 'OK';
            }
            else if (data.statusid === status.error) {
              Severity: Major
              Found in app/services/PRTG.js and 1 other location - About 6 hrs to fix
              app/services/PRTG.js on lines 62..84

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 155.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Function exports has 149 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              module.exports = function () {
    var self = this,
        requestWithDefaults,
        flatten = function (arrayOfArray) {
            return [].concat.apply([], arrayOfArray);
              Severity: Major
              Found in app/services/Jenkins.js - About 5 hrs to fix

                Function exports has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
                Open

                module.exports = function() {
  var self = this,
    requestBuilds = function (callback) {
      const {
        vcs,
                Severity: Minor
                Found in app/services/CircleCI.js - About 5 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function exports has 129 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                module.exports = function() {
  var configuration = {};
  var graph;

  return {
                Severity: Major
                Found in app/services/Buildkite.js - About 5 hrs to fix

                  Function exports has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
                  Open

                  module.exports = function () {
    var self = this,
        makeUrl = function () {
            return 'https://api.bitbucket.org/2.0/repositories/' + (self.configuration.teamname || self.configuration.username) + '/' + self.configuration.slug + '/pipelines/?sort=-created_on&pagelen=1';
        },
                  Severity: Minor
                  Found in app/services/BitbucketPipelines.js - About 5 hrs to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Severity
                  Category
                  Status
                  Source
                  Language