Sign upLogin

marcells/node-build-monitor

View on GitHub
Star
app/services/PRTG.js

Summary

Maintainability
D
2 days
Test Coverage

Function exports has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
Open

module.exports = function () {
    var self = this,
        getSensors = function(callback) {
            var url =  self.configuration.url +
                '/api/getsensordetails.json?id=' + self.configuration.sensorId +
Severity: Minor
Found in app/services/PRTG.js - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function exports has 98 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function () {
    var self = this,
        getSensors = function(callback) {
            var url =  self.configuration.url +
                '/api/getsensordetails.json?id=' + self.configuration.sensorId +
Severity: Major
Found in app/services/PRTG.js - About 3 hrs to fix

    Avoid too many return statements within this function.
    Open

                    return 'Gray';
    Severity: Major
    Found in app/services/PRTG.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                      return 'Paused';
      Severity: Major
      Found in app/services/PRTG.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                        return '#477ec0';
        Severity: Major
        Found in app/services/PRTG.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                          return 'Unknown';
          Severity: Major
          Found in app/services/PRTG.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                            return '#f59c00';
            Severity: Major
            Found in app/services/PRTG.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                              return 'Unusual';
              Severity: Major
              Found in app/services/PRTG.js - About 30 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        getBuildStatusText = function(data) {
            if (data.statusid === status.ok) {
                return 'OK';
            }
            else if (data.statusid === status.error) {
                Severity: Major
                Found in app/services/PRTG.js and 1 other location - About 6 hrs to fix
                app/services/PRTG.js on lines 62..84

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 155.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        getBuildStatus = function(data) {
            if (data.statusid === status.ok) {
                return 'Green';
            }
            else if (data.statusid === status.error) {
                Severity: Major
                Found in app/services/PRTG.js and 1 other location - About 6 hrs to fix
                app/services/PRTG.js on lines 85..107

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 155.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                const status = Object.freeze({
    ok: "3",
    error: "5",
    errorConfirmed: "13",
    warning: "4",
                Severity: Minor
                Found in app/services/PRTG.js and 1 other location - About 30 mins to fix
                app/services/Tfs.js on lines 41..48

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 45.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status