Sign upLogin

marcells/node-build-monitor

View on GitHub
Star
app/services/TeamCity.js

Summary

Maintainability
F
3 days
Test Coverage

Function exports has a Cognitive Complexity of 56 (exceeds 5 allowed). Consider refactoring.
Open

module.exports = function () {
    var self = this,
        selectMany = function (array, selector) {
            return array.map(selector).reduce(function (x, y) { return x.concat(y); }, []);
        },
Severity: Minor
Found in app/services/TeamCity.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function exports has 162 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function () {
    var self = this,
        selectMany = function (array, selector) {
            return array.map(selector).reduce(function (x, y) { return x.concat(y); }, []);
        },
Severity: Major
Found in app/services/TeamCity.js - About 6 hrs to fix

    Avoid too many return statements within this function.
    Open

                if (build.status === "ERROR") return "Error";
    Severity: Major
    Found in app/services/TeamCity.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                  if (build.status === "UNKNOWN") return "Gray";
      Severity: Major
      Found in app/services/TeamCity.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                    if (build.status === "ERROR") return "Red";
        Severity: Major
        Found in app/services/TeamCity.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                      if (build.status === "FAILURE") return "Failure";
          Severity: Major
          Found in app/services/TeamCity.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                        return null;
            Severity: Major
            Found in app/services/TeamCity.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                          return null;
              Severity: Major
              Found in app/services/TeamCity.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                            if (build.status === "FAILURE") return "Red";
                Severity: Major
                Found in app/services/TeamCity.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                              if (build.status === "UNKNOWN") return "Unknown";
                  Severity: Major
                  Found in app/services/TeamCity.js - About 30 mins to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            getStatusText = function (build) {
            if (build.running) return "Running";
            if (build.canceledInfo) return "Canceled";
            if (build.failedToStart) return "Failed to Start";
                    Severity: Major
                    Found in app/services/TeamCity.js and 1 other location - About 3 hrs to fix
                    app/services/TeamCity.js on lines 116..127

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 107.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            getStatus = function (build) {
            if (build.running) return "Blue";
            if (build.canceledInfo) return "Gray";
            if (build.failedToStart) return "Red";
                    Severity: Major
                    Found in app/services/TeamCity.js and 1 other location - About 3 hrs to fix
                    app/services/TeamCity.js on lines 128..139

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 107.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                            makeRequest = function (url, callback) {
          request.makeRequest({
            authentication: self.configuration.authentication,
            url: url,
            username: self.configuration.username,
                    Severity: Major
                    Found in app/services/TeamCity.js and 1 other location - About 2 hrs to fix
                    app/services/Tfs2015.js on lines 14..22

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 80.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status