Sign upLogin

marcells/node-build-monitor

View on GitHub
Star
app/services/Tfs.js

Summary

Maintainability
F
3 days
Test Coverage

Function VSTSRestBuilds has a Cognitive Complexity of 73 (exceeds 5 allowed). Consider refactoring.
Open

function VSTSRestBuilds() {
  let basicAuth = null;
  let url = null;
  let project = null;
  let collection = null;
Severity: Minor
Found in app/services/Tfs.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function VSTSRestBuilds has 236 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function VSTSRestBuilds() {
  let basicAuth = null;
  let url = null;
  let project = null;
  let collection = null;
Severity: Major
Found in app/services/Tfs.js - About 1 day to fix

    Function getListOfBuilds has 95 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      const getListOfBuilds = (callback) => {
    const apiUrl = `${url}/${collection}/${project}/_apis/build/builds?api-version=${apiVersion}${params}`;
    let options = {
      url : apiUrl,
      headers: {
    Severity: Major
    Found in app/services/Tfs.js - About 3 hrs to fix

      Function transformer has 46 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          const transformer = (build) => {
      let color = colorScheme[
        build.result ?
          resultFilter[build.result] :
          (build.status === statusFilter.notStarted ?
      Severity: Minor
      Found in app/services/Tfs.js - About 1 hr to fix

        Function getLatestBuildStep has 39 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          const getLatestBuildStep = (build, callback) => {
    const timelineURL = build.timeline;
    if (!timelineURL || timelineURL === '') {
      console.log('no timeline url');
      callback(null, build);
        Severity: Minor
        Found in app/services/Tfs.js - About 1 hr to fix

          Function getPreviousBuilds has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            const getPreviousBuilds = (currentBuilds, callback) => {
    async.map(previousBuildsToGet, (build, callback) => {
      let def = build.definition;

      // If we already have a previous build, then we don't need to get another one
          Severity: Minor
          Found in app/services/Tfs.js - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              this.check = (callback) => {
    if (basicAuth && url && project) {
      getListOfBuilds(callback);
      return;
    }
            Severity: Major
            Found in app/services/Tfs.js and 1 other location - About 1 hr to fix
            app/services/TfsRelease.js on lines 97..104

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 55.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              const statusFilter = Object.freeze({
    inProgress: 'inProgress',
    completed:  'completed',
    cancelling: 'cancelling',
    postponed:  'postponed',
            Severity: Minor
            Found in app/services/Tfs.js and 1 other location - About 30 mins to fix
            app/services/PRTG.js on lines 5..12

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status