Sign upLogin

marcelobelli/PyNFSe

View on GitHub
Star
tests/pr/curitiba/test_curitiba_serializacao_comunicacao.py

Summary

Maintainability
B
5 hrs
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    def test_consultar_lote_rps(self):
        xml_consultar_lote = s.consulta_lote_rps(self.prestador, "636174090357960929")

        xml_consultar_lote_expected = xml_expected("ConsultarLoteRpsEnvio.xml")
Severity: Major
Found in tests/pr/curitiba/test_curitiba_serializacao_comunicacao.py and 1 other location - About 1 hr to fix
tests/pr/curitiba/test_curitiba_serializacao_comunicacao.py on lines 34..39

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 39.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    def test_consultar_situacao_lote_rps(self):
        xml_consultar_situacao_lote = s.consulta_situacao_lote_rps(self.prestador, "636174090357960929")

        xml_consultar_situacao_lote_expected = xml_expected("ConsultarSituacaoLoteRpsEnvio.xml")
Severity: Major
Found in tests/pr/curitiba/test_curitiba_serializacao_comunicacao.py and 1 other location - About 1 hr to fix
tests/pr/curitiba/test_curitiba_serializacao_comunicacao.py on lines 49..54

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 39.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    def test_cancelar_nfse(self):
        xml_cancelar_nfse = s.cancela_nfse(self.pedido_cancelamento_nfse)

        xml_cancelar_nfse_expected = xml_expected("CancelarNfseEnvio.xml")
Severity: Major
Found in tests/pr/curitiba/test_curitiba_serializacao_comunicacao.py and 2 other locations - About 1 hr to fix
tests/pr/curitiba/test_curitiba_serializacao_comunicacao.py on lines 27..32
tests/pr/curitiba/test_curitiba_serializacao_comunicacao.py on lines 41..47

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 38.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    def test_consultar_nfse_por_rps(self):

        xml_consultar_nfse = s.consulta_nfse_por_rps(self.rps)

        xml_consultar_nfse_expected = xml_expected("ConsultarNfseRpsEnvio.xml")
Severity: Major
Found in tests/pr/curitiba/test_curitiba_serializacao_comunicacao.py and 2 other locations - About 1 hr to fix
tests/pr/curitiba/test_curitiba_serializacao_comunicacao.py on lines 27..32
tests/pr/curitiba/test_curitiba_serializacao_comunicacao.py on lines 56..61

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 38.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    def test_envio_lote_rps(self):
        xml_lote_rps = s.envio_lote_rps(self.lote_rps)

        xml_lote_rps_expected = xml_expected("EnviarLoteRpsEnvio.xml")
Severity: Major
Found in tests/pr/curitiba/test_curitiba_serializacao_comunicacao.py and 2 other locations - About 1 hr to fix
tests/pr/curitiba/test_curitiba_serializacao_comunicacao.py on lines 41..47
tests/pr/curitiba/test_curitiba_serializacao_comunicacao.py on lines 56..61

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 38.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Line too long (84 > 79 characters)
Open

        xml_consultar_nfse = s.consulta_nfse_por_numero(self.prestador, numero_nota)
Severity: Minor
Found in tests/pr/curitiba/test_curitiba_serializacao_comunicacao.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

Line too long (85 > 79 characters)
Open

        xml_consultar_nfse_expected = xml_expected("ConsultarNfseEnvio-por_nota.xml")
Severity: Minor
Found in tests/pr/curitiba/test_curitiba_serializacao_comunicacao.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

Line too long (86 > 79 characters)
Open

        xml_consultar_lote = s.consulta_lote_rps(self.prestador, "636174090357960929")
Severity: Minor
Found in tests/pr/curitiba/test_curitiba_serializacao_comunicacao.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

Line too long (104 > 79 characters)
Open

        xml_consultar_situacao_lote = s.consulta_situacao_lote_rps(self.prestador, "636174090357960929")
Severity: Minor
Found in tests/pr/curitiba/test_curitiba_serializacao_comunicacao.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

Line too long (96 > 79 characters)
Open

        xml_consultar_situacao_lote_expected = xml_expected("ConsultarSituacaoLoteRpsEnvio.xml")
Severity: Minor
Found in tests/pr/curitiba/test_curitiba_serializacao_comunicacao.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

Line too long (91 > 79 characters)
Open

        self.assertEqual(xml_consultar_situacao_lote, xml_consultar_situacao_lote_expected)
Severity: Minor
Found in tests/pr/curitiba/test_curitiba_serializacao_comunicacao.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

Line too long (85 > 79 characters)
Open

        xml_consultar_nfse_expected = xml_expected("ConsultarNfseEnvio-por_data.xml")
Severity: Minor
Found in tests/pr/curitiba/test_curitiba_serializacao_comunicacao.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

Line too long (95 > 79 characters)
Open

        xml_consultar_nfse = s.consulta_nfse_por_data(self.prestador, data_inicial, data_final)
Severity: Minor
Found in tests/pr/curitiba/test_curitiba_serializacao_comunicacao.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

Line too long (89 > 79 characters)
Open

from tests.pr.curitiba.basetestesserializacao import BaseTestesSerializacao, xml_expected
Severity: Minor
Found in tests/pr/curitiba/test_curitiba_serializacao_comunicacao.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

There are no issues that match your filters.

Category
Status