marceloboeira/feedcast

View on GitHub
app/models/episode.rb

Summary

Maintainability
A
0 mins
Test Coverage
A
100%

Line is too long. [84/80]
Open

    Episode.find_by(_slugs: episode_slug, channel_id: Channel.find(channel_slug).id)
Severity: Minor
Found in app/models/episode.rb by rubocop

Use proc instead of Proc.new.
Open

  validates :published_at, presence: true, date: { before: Proc.new{ PUBLISHING_IN_ADVANCE_INTERVAL.from_now } }
Severity: Minor
Found in app/models/episode.rb by rubocop

This cops checks for uses of Proc.new where Kernel#proc would be more appropriate.

Example:

# bad
p = Proc.new { |n| puts n }

# good
p = proc { |n| puts n }

Use the lambda method for multiline lambdas.
Open

  scope :not_analysed, -> do
Severity: Minor
Found in app/models/episode.rb by rubocop

This cop (by default) checks for uses of the lambda literal syntax for single line lambdas, and the method call syntax for multiline lambdas. It is configurable to enforce one of the styles for both single line and multiline lambdas as well.

Example: EnforcedStyle: linecountdependent (default)

# bad
f = lambda { |x| x }
f = ->(x) do
      x
    end

# good
f = ->(x) { x }
f = lambda do |x|
      x
    end

Example: EnforcedStyle: lambda

# bad
f = ->(x) { x }
f = ->(x) do
      x
    end

# good
f = lambda { |x| x }
f = lambda do |x|
      x
    end

Example: EnforcedStyle: literal

# bad
f = lambda { |x| x }
f = lambda do |x|
      x
    end

# good
f = ->(x) { x }
f = ->(x) do
      x
    end

Use 2 (not 1) spaces for indenting an expression spanning multiple lines.
Open

     .and(:"audio.error_count".lt => Audio::MAX_ERROR_COUNT)
Severity: Minor
Found in app/models/episode.rb by rubocop

This cop checks the indentation of the method name part in method calls that span more than one line.

Example: EnforcedStyle: aligned

# bad
while myvariable
.b
  # do something
end

# good
while myvariable
      .b
  # do something
end

# good
Thing.a
     .b
     .c

Example: EnforcedStyle: indented

# good
while myvariable
  .b

  # do something
end

Example: EnforcedStyle: indentedrelativeto_receiver

# good
while myvariable
        .a
        .b

  # do something
end

# good
myvariable = Thing
               .a
               .b
               .c

Missing magic comment # frozen_string_literal: true.
Open

class Episode
Severity: Minor
Found in app/models/episode.rb by rubocop

This cop is designed to help upgrade to Ruby 3.0. It will add the comment # frozen_string_literal: true to the top of files to enable frozen string literals. Frozen string literals may be default in Ruby 3.0. The comment will be added below a shebang and encoding comment. The frozen string literal comment is only valid in Ruby 2.3+.

Example: EnforcedStyle: when_needed (default)

# The `when_needed` style will add the frozen string literal comment
# to files only when the `TargetRubyVersion` is set to 2.3+.
# bad
module Foo
  # ...
end

# good
# frozen_string_literal: true

module Foo
  # ...
end

Example: EnforcedStyle: always

# The `always` style will always add the frozen string literal comment
# to a file, regardless of the Ruby version or if `freeze` or `<<` are
# called on a string literal.
# bad
module Bar
  # ...
end

# good
# frozen_string_literal: true

module Bar
  # ...
end

Example: EnforcedStyle: never

# The `never` will enforce that the frozen string literal comment does
# not exist in a file.
# bad
# frozen_string_literal: true

module Baz
  # ...
end

# good
module Baz
  # ...
end

Space missing to the left of {.
Open

  validates :published_at, presence: true, date: { before: Proc.new{ PUBLISHING_IN_ADVANCE_INTERVAL.from_now } }
Severity: Minor
Found in app/models/episode.rb by rubocop

Checks that block braces have or don't have a space before the opening brace depending on configuration.

Example:

# bad
foo.map{ |a|
  a.bar.to_s
}

# good
foo.map { |a|
  a.bar.to_s
}

Line is too long. [112/80]
Open

  validates :published_at, presence: true, date: { before: Proc.new{ PUBLISHING_IN_ADVANCE_INTERVAL.from_now } }
Severity: Minor
Found in app/models/episode.rb by rubocop

Missing top-level class documentation comment.
Open

class Episode
Severity: Minor
Found in app/models/episode.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

There are no issues that match your filters.

Category
Status