src/PAGI/DialDescriptor/DAHDIDialDescriptor.php
The method __construct has a boolean flag argument $isGroup, which is a certain sign of a Single Responsibility Principle violation. Open
Open
public function __construct($target, $identifier, $isGroup = true, $descendantOrder = true)- Read upRead up
- Exclude checks
BooleanArgumentFlag
Since: 1.4.0
A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.
Example
class Foo {
public function bar($flag = true) {
}
}Source https://phpmd.org/rules/cleancode.html#booleanargumentflag
The method __construct has a boolean flag argument $descendantOrder, which is a certain sign of a Single Responsibility Principle violation. Open
Open
public function __construct($target, $identifier, $isGroup = true, $descendantOrder = true)- Read upRead up
- Exclude checks
BooleanArgumentFlag
Since: 1.4.0
A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.
Example
class Foo {
public function bar($flag = true) {
}
}