Sign upLogin

marcojetson/freckle

View on GitHub
Star
lib/Mapping.php

Summary

Maintainability
B
4 hrs
Test Coverage

Method __toString has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function __toString()
    {
        $header = '';

        $parts = explode('\\', $this->entityClass());
Severity: Minor
Found in lib/Mapping.php - About 1 hr to fix

    Method __construct has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function __construct(array $definition)
    {
        $this->entityClass = $this->resolveEntityClass($definition);
        $this->table = $this->resolveTable($definition);
    Severity: Minor
    Found in lib/Mapping.php - About 1 hr to fix

      Function __construct has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          public function __construct(array $definition)
    {
        $this->entityClass = $this->resolveEntityClass($definition);
        $this->table = $this->resolveTable($definition);
      Severity: Minor
      Found in lib/Mapping.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function __toString has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public function __toString()
    {
        $header = '';

        $parts = explode('\\', $this->entityClass());
      Severity: Minor
      Found in lib/Mapping.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Missing class import via use statement (line '109', column '23').
      Open

                  throw new \InvalidArgumentException('$entityClass must be a subclass of ' . Entity::class);
      Severity: Minor
      Found in lib/Mapping.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      There are no issues that match your filters.

      Category
      Status