marcojetson/freckle

View on GitHub
lib/Query.php

Summary

Maintainability
A
35 mins
Test Coverage

Function clause has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    protected function clause($conditions, $glue = 'and')
    {
        $restrictions = [];
        foreach ($conditions as $field => $value) {
            if ($field === 'and' || $field === 'or') {
Severity: Minor
Found in lib/Query.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Missing class import via use statement (line '123', column '20').
Open

        return new \ArrayIterator($this->run());
Severity: Minor
Found in lib/Query.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '167', column '19').
Open

        throw new \RuntimeException('Freckle\Query is read-only');
Severity: Minor
Found in lib/Query.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '178', column '23').
Open

            throw new \BadMethodCallException('Call to undefined method ' . get_class($this) . '::' . $name . '()');
Severity: Minor
Found in lib/Query.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '208', column '27').
Open

                throw new \InvalidArgumentException('Invalid operator ' . $operatorName);
Severity: Minor
Found in lib/Query.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method count has a boolean flag argument $limit, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function count($limit = true)
Severity: Minor
Found in lib/Query.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Missing class import via use statement (line '159', column '19').
Open

        throw new \RuntimeException('Freckle\Query is read-only');
Severity: Minor
Found in lib/Query.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Avoid using static access to class '\Freckle\Operator\Operator' in method 'operator'.
Open

        return Operator::get($name);
Severity: Minor
Found in lib/Query.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

There are no issues that match your filters.

Category
Status