marcomontalbano/html-miner

View on GitHub

Showing 8 of 8 total issues

File test.js has 423 lines of code (exceeds 250 allowed). Consider refactoring.
Open

'use strict';

var htmlMiner = require('../lib/');

var chai = require('chai');
Severity: Minor
Found in test/test.js - About 6 hrs to fix

    Function _fetchSpecialKeys has 54 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    var _fetchSpecialKeys = function($, selector, memo)
    {
        var _specialKeys = {
    
            _each_ : function($, specialKeySelector, selector, memo) {
    Severity: Major
    Found in lib/index.js - About 2 hrs to fix

      Function has a complexity of 7.
      Open

      var _htmlMiner = function(html, originalSelector, memo) {
      Severity: Minor
      Found in lib/index.js by eslint

      Limit Cyclomatic Complexity (complexity)

      Cyclomatic complexity measures the number of linearly independent paths through a program's source code. This rule allows setting a cyclomatic complexity threshold.

      function a(x) {
          if (true) {
              return x; // 1st path
          } else if (false) {
              return x+1; // 2nd path
          } else {
              return 4; // 3rd path
          }
      }

      Rule Details

      This rule is aimed at reducing code complexity by capping the amount of cyclomatic complexity allowed in a program. As such, it will warn when the cyclomatic complexity crosses the configured threshold (default is 20).

      Examples of incorrect code for a maximum of 2:

      /*eslint complexity: ["error", 2]*/
      
      function a(x) {
          if (true) {
              return x;
          } else if (false) {
              return x+1;
          } else {
              return 4; // 3rd path
          }
      }

      Examples of correct code for a maximum of 2:

      /*eslint complexity: ["error", 2]*/
      
      function a(x) {
          if (true) {
              return x;
          } else {
              return 4;
          }
      }

      Options

      Optionally, you may specify a max object property:

      "complexity": ["error", 2]

      is equivalent to

      "complexity": ["error", { "max": 2 }]

      Deprecated: the object property maximum is deprecated. Please use the property max instead.

      When Not To Use It

      If you can't determine an appropriate complexity limit for your code, then it's best to disable this rule.

      Further Reading

      Related Rules

      • [max-depth](max-depth.md)
      • [max-len](max-len.md)
      • [max-nested-callbacks](max-nested-callbacks.md)
      • [max-params](max-params.md)
      • [max-statements](max-statements.md) Source: http://eslint.org/docs/rules/

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

                  button   : {
                      _container_: 'a.btn',
                      text: function(arg) { return arg.$scope.text(); },
                      href: function(arg) { return arg.$scope.attr('href'); }
                  }
      Severity: Major
      Found in examples/demo.js and 2 other locations - About 1 hr to fix
      examples/demo.js on lines 27..31
      examples/demo.js on lines 50..54

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 62.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

                  button   : {
                      _container_: 'a.btn',
                      text: function(arg) { return arg.$scope.text(); },
                      href: function(arg) { return arg.$scope.attr('href'); }
                  }
      Severity: Major
      Found in examples/demo.js and 2 other locations - About 1 hr to fix
      examples/demo.js on lines 27..31
      examples/demo.js on lines 37..41

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 62.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

                  links: {
                      _each_: '.nav-item:not(.dropdown) a',
                      text: function(arg) { return arg.$scope.text(); },
                      href: function(arg) { return arg.$scope.attr('href'); }
                  }
      Severity: Major
      Found in examples/demo.js and 2 other locations - About 1 hr to fix
      examples/demo.js on lines 37..41
      examples/demo.js on lines 50..54

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 62.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function _fetchSelector has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      var _fetchSelector = function(html, selector, memo, $, scopeData) {
      Severity: Minor
      Found in lib/index.js - About 35 mins to fix

        Function _htmlMiner has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        var _htmlMiner = function(html, originalSelector, memo) {
        
            if ( _validateHtml(html) === false ) {
                return undefined;
            }
        Severity: Minor
        Found in lib/index.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language