Sign upLogin

marcusgsta/comment

View on GitHub
Star

Showing 11 of 11 total issues

Method __construct has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function __construct(DIInterface $di, $acronym)
    {
        parent::__construct($di);

        $user = new User();
Severity: Minor
Found in src/User/HTMLForm/EditUserForm.php - About 1 hr to fix

    Method __construct has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function __construct(DIInterface $di)
    {
        parent::__construct($di);

        $editable = "hidden";
    Severity: Minor
    Found in src/User/HTMLForm/CreateUserForm.php - About 1 hr to fix

      Method __construct has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function __construct(DIInterface $di, $data)
    {
        parent::__construct($di);

        $comment = new Comment();
      Severity: Minor
      Found in src/Comment/HTMLForm/EditCommentForm.php - About 1 hr to fix

        Method renderPage has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function renderPage($data, $status = 200)
    {
        $data["stylesheets"] = ["css/bootstrap.min.css", "css/style.css", "css/remserver.css"];
        $data["javascripts"] = [
            "js/jquery-3.2.1.slim.min.js",
        Severity: Minor
        Found in src/Page/PageRender.php - About 1 hr to fix

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

              public function getPostCreateComment()
    {
        $title      = "A create comment page";
        $view       = $this->di->get("view");
        $pageRender = $this->di->get("pageRender");
          Severity: Major
          Found in src/Comment/CommentController.php and 3 other locations - About 1 hr to fix
          src/Comment/CommentController.php on lines 149..165
          src/User/UserController.php on lines 68..85
          src/User/UserController.php on lines 98..114

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 106.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

              public function deleteComment()
    {
        $title      = "A delete comments page";
        $view       = $this->di->get("view");
        $pageRender = $this->di->get("pageRender");
          Severity: Major
          Found in src/Comment/CommentController.php and 3 other locations - About 1 hr to fix
          src/Comment/CommentController.php on lines 82..98
          src/User/UserController.php on lines 68..85
          src/User/UserController.php on lines 98..114

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 106.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

              public function getPostLogin()
    {
        $title      = "A login page";
        $view       = $this->di->get("view");
        $pageRender = $this->di->get("pageRender");
          Severity: Major
          Found in src/User/UserController.php and 3 other locations - About 1 hr to fix
          src/Comment/CommentController.php on lines 82..98
          src/Comment/CommentController.php on lines 149..165
          src/User/UserController.php on lines 98..114

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 106.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

              public function getPostCreateUser()
    {
        $title      = "A create user page";
        $view       = $this->di->get("view");
        $pageRender = $this->di->get("pageRender");
          Severity: Major
          Found in src/User/UserController.php and 3 other locations - About 1 hr to fix
          src/Comment/CommentController.php on lines 82..98
          src/Comment/CommentController.php on lines 149..165
          src/User/UserController.php on lines 68..85

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 106.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Method getHtml has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function getHtml()
    {
        $items = $this->config;

        $page = basename($_SERVER['REQUEST_URI']);
          Severity: Minor
          Found in src/Navbar/Navbar.php - About 1 hr to fix

            Method __construct has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function __construct(DIInterface $di)
    {
        parent::__construct($di);
        $page = $this->di->session->get("previous");
        $acronym = $this->di->session->get("user");
            Severity: Minor
            Found in src/Comment/HTMLForm/CreateCommentForm.php - About 1 hr to fix

              Function getHtml has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function getHtml()
    {
        $items = $this->config;

        $page = basename($_SERVER['REQUEST_URI']);
              Severity: Minor
              Found in src/Navbar/Navbar.php - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language