mariuz/firebirdwebadmin

View on GitHub

Showing 162 of 204 total issues

File tables.php has 365 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
// File           tables.php / FirebirdWebAdmin
// Purpose        acting with the tables of the selected database
// Author         Lutz Brueckner <irie@gmx.de>
// Copyright      (c) 2000-2006 by Lutz Brueckner,
Severity: Minor
Found in tables.php - About 4 hrs to fix

    File javascript.inc.php has 342 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    // File           javascript.inc.php / FirebirdWebAdmin
    // Purpose        inline JavaScript functions
    // Author         Lutz Brueckner <irie@gmx.de>
    // Copyright      (c) 2000-2006 by Lutz Brueckner,
    Severity: Minor
    Found in inc/javascript.inc.php - About 4 hrs to fix

      Method globalize_session_vars has 98 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function globalize_session_vars()
      {
          $session_var_names =
              array('s_init',
                    's_cookies',
      Severity: Major
      Found in inc/session.inc.php - About 3 hrs to fix

        Function modify_index has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
        Open

        function modify_index($iname)
        {
            global $dbhandle, $indices, $fb_error, $lsql;
        
            // alter the active/inactive status if the change was selected
        Severity: Minor
        Found in inc/indices.inc.php - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function get_systable_html has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
        Open

        function get_systable_html($table, $s_systable)
        {
            $html = "<table id=\"systable\" class=\"table table-bordered table-hover tsep\" cellpadding=\"2\">\n<thead><tr>\n";
            foreach (array_keys($table) as $colname) {
                if ($s_systable['order'] == $colname) {
        Severity: Minor
        Found in inc/system_table.inc.php - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method get_column_constraint_definition has 84 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function get_column_constraint_definition($coldefs, $idx)
        {
            global $fk_actions, $tb_strings;
        
            $fk_name = isset($coldefs['fk_name'])   ? $coldefs['fk_name']   : '';
        Severity: Major
        Found in inc/panel_elements.inc.php - About 3 hrs to fix

          Function get_tables_names has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
          Open

          function get_tables_names($restrictions = array())
          {
              global $s_tables, $s_login;
          
              $rights = array('S' => 'select',
          Severity: Minor
          Found in inc/panel_elements.inc.php - About 3 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method get_datatype_definition has 77 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function get_datatype_definition($idx, $title, $rowspan = 1, $collate = false)
          {
              global $s_coldefs, $tb_strings;
          
              // preselect values for the form elements
          Severity: Major
          Found in inc/panel_elements.inc.php - About 3 hrs to fix

            File procedures.inc.php has 292 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            <?php
            // File           procedures.inc.php / FirebirdWebAdmin
            // Purpose        functions working with stored procedures, included from accessories.php
            // Author         Lutz Brueckner <irie@gmx.de>
            // Copyright      (c) 2000, 2001,2002, 2003, 2004, 2005 by Lutz Brueckner,
            Severity: Minor
            Found in inc/procedures.inc.php - About 3 hrs to fix

              Function build_coldef has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
              Open

              function build_coldef($idx, $mode = 'create')
              {
                  global $s_coldefs;
              
                  if (!isset($s_coldefs[$idx]['name']))
              Severity: Minor
              Found in inc/functions.inc.php - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method get_opened_procedure has 70 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              function get_opened_procedure($name, $procedure, $url)
              {
                  global $dbhandle, $tb_strings, $acc_strings, $ptitle_strings;
              
                  $in = $out = '';
              Severity: Major
              Found in inc/procedures.inc.php - About 2 hrs to fix

                Method cleanup_session has 69 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                function cleanup_session()
                {
                    $GLOBALS['s_modify_table'] = '';
                    $GLOBALS['s_enter_name'] = '';
                    $GLOBALS['s_tables'] = array();
                Severity: Major
                Found in inc/session.inc.php - About 2 hrs to fix

                  Function get_systable has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
                  Open

                  function get_systable($s_systable)
                  {
                      global $dbhandle;
                  
                      // get the field names and types
                  Severity: Minor
                  Found in inc/system_table.inc.php - About 2 hrs to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method display_table has 65 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  function display_table($wt)
                  {
                      global $dbhandle, $sql_strings, $button_strings, $s_watch_buffer, $s_cust;
                  
                      if ($wt['table'] == '' || !is_array($wt['columns'])) {
                  Severity: Major
                  Found in inc/handle_watchtable.inc.php - About 2 hrs to fix

                    Function set_customize_cookie has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
                    Open

                    function set_customize_cookie($customize)
                    {
                    
                        // don't save rubbish if the session is gone
                        if (empty($customize['color'])) {
                    Severity: Minor
                    Found in inc/functions.inc.php - About 2 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    File xml_http_request_server.php has 272 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    <?php
                    // File           inc/xml_http_request_server.php / FirebirdWebAdmin
                    // Purpose        answers to the XMLHttpRequests
                    // Author         Lutz Brueckner <irie@gmx.de>
                    // Copyright      (c) 2000-2006 by Lutz Brueckner,
                    Severity: Minor
                    Found in inc/xml_http_request_server.php - About 2 hrs to fix

                      File triggers.inc.php has 271 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      <?php
                      // File           triggers.inc.php / FirebirdWebAdmin
                      // Purpose        functions working with triggerss, included from accessories.php
                      // Author         Lutz Brueckner <irie@gmx.de>
                      // Copyright      (c) 2000, 2001, 2002, 2003, 2004, 2005 by Lutz Brueckner,
                      Severity: Minor
                      Found in inc/triggers.inc.php - About 2 hrs to fix

                        File admin.php has 270 lines of code (exceeds 250 allowed). Consider refactoring.
                        Open

                        <?php
                        // Purpose        panels for database administration tasks, gsec, gbak etc.
                        // Author         Lutz Brueckner <irie@gmx.de>
                        // Copyright      (c) 2000-2006 by Lutz Brueckner,
                        //                published under the terms of the GNU General Public Licence v.2,
                        Severity: Minor
                        Found in admin.php - About 2 hrs to fix

                          Method sql_format_options_table has 61 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                          function sql_format_options_table($export)
                          {
                              global $dt_strings;
                          
                              return '
                          Severity: Major
                          Found in inc/export.inc.php - About 2 hrs to fix

                            Method csv_format_options_table has 61 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                            function csv_format_options_table($export)
                            {
                                global $dt_strings;
                            
                                return '
                            Severity: Major
                            Found in inc/export.inc.php - About 2 hrs to fix
                              Severity
                              Category
                              Status
                              Source
                              Language