markdown-note/markdown-notes

View on GitHub

Showing 144 of 144 total issues

Rule doesn't have all its properties in alphabetical order.
Open

.spinner {
Severity: Minor
Found in src/css/style.css by csslint

Use path.join() or path.resolve() instead of + to create paths.
Open

var _appConfig = require(__dirname + '/../../config.js');
Severity: Minor
Found in src/renderer/main-window.js by eslint

Disallow string concatenation when using __dirname and __filename (no-path-concat)

In Node.js, the __dirname and __filename global variables contain the directory path and the file path of the currently executing script file, respectively. Sometimes, developers try to use these variables to create paths to other files, such as:

var fullPath = __dirname + "/foo.js";

However, there are a few problems with this. First, you can't be sure what type of system the script is running on. Node.js can be run on any computer, including Windows, which uses a different path separator. It's very easy, therefore, to create an invalid path using string concatenation and assuming Unix-style separators. There's also the possibility of having double separators, or otherwise ending up with an invalid path.

In order to avoid any confusion as to how to create the correct path, Node.js provides the path module. This module uses system-specific information to always return the correct value. So you can rewrite the previous example as:

var fullPath = path.join(__dirname, "foo.js");

This example doesn't need to include separators as path.join() will do it in the most appropriate manner. Alternately, you can use path.resolve() to retrieve the fully-qualified path:

var fullPath = path.resolve(__dirname, "foo.js");

Both path.join() and path.resolve() are suitable replacements for string concatenation wherever file or directory paths are being created.

Rule Details

This rule aims to prevent string concatenation of directory paths in Node.js

Examples of incorrect code for this rule:

/*eslint no-path-concat: "error"*/

var fullPath = __dirname + "/foo.js";

var fullPath = __filename + "/foo.js";

Examples of correct code for this rule:

/*eslint no-path-concat: "error"*/

var fullPath = dirname + "/foo.js";

When Not To Use It

If you want to allow string concatenation of path names. Source: http://eslint.org/docs/rules/

Rule doesn't have all its properties in alphabetical order.
Open

.spinner .circle3 { right: 0; bottom: 0; }
Severity: Minor
Found in src/css/style.css by csslint

Standard property 'transform' should come after vendor-prefixed property '-webkit-transform'.
Open

    -webkit-transform: scale(1.0);
Severity: Minor
Found in src/css/style.css by csslint

Using width with padding can sometimes make elements larger than you expect.
Open

    padding: 0.5em 0.5em;
Severity: Minor
Found in src/css/style.css by csslint

Use path.join() or path.resolve() instead of + to create paths.
Open

var _appConfig = require(__dirname + '/../../../config.js');
Severity: Minor
Found in src/browser/notes/note-editor.js by eslint

Disallow string concatenation when using __dirname and __filename (no-path-concat)

In Node.js, the __dirname and __filename global variables contain the directory path and the file path of the currently executing script file, respectively. Sometimes, developers try to use these variables to create paths to other files, such as:

var fullPath = __dirname + "/foo.js";

However, there are a few problems with this. First, you can't be sure what type of system the script is running on. Node.js can be run on any computer, including Windows, which uses a different path separator. It's very easy, therefore, to create an invalid path using string concatenation and assuming Unix-style separators. There's also the possibility of having double separators, or otherwise ending up with an invalid path.

In order to avoid any confusion as to how to create the correct path, Node.js provides the path module. This module uses system-specific information to always return the correct value. So you can rewrite the previous example as:

var fullPath = path.join(__dirname, "foo.js");

This example doesn't need to include separators as path.join() will do it in the most appropriate manner. Alternately, you can use path.resolve() to retrieve the fully-qualified path:

var fullPath = path.resolve(__dirname, "foo.js");

Both path.join() and path.resolve() are suitable replacements for string concatenation wherever file or directory paths are being created.

Rule Details

This rule aims to prevent string concatenation of directory paths in Node.js

Examples of incorrect code for this rule:

/*eslint no-path-concat: "error"*/

var fullPath = __dirname + "/foo.js";

var fullPath = __filename + "/foo.js";

Examples of correct code for this rule:

/*eslint no-path-concat: "error"*/

var fullPath = dirname + "/foo.js";

When Not To Use It

If you want to allow string concatenation of path names. Source: http://eslint.org/docs/rules/

Standard property 'transform' should come after vendor-prefixed property '-webkit-transform'.
Open

    -webkit-transform: scale(0.0);
Severity: Minor
Found in src/css/style.css by csslint

Rule doesn't have all its properties in alphabetical order.
Open

.modal kbd {
Severity: Minor
Found in src/css/style.css by csslint

Don't use IDs in selectors.
Open

#dlgAbout .logo {
Severity: Minor
Found in src/css/style.css by csslint

Use path.join() or path.resolve() instead of + to create paths.
Open

var _appConfig = require(__dirname + '/../../../config.js');
Severity: Minor
Found in src/browser/notes/note.js by eslint

Disallow string concatenation when using __dirname and __filename (no-path-concat)

In Node.js, the __dirname and __filename global variables contain the directory path and the file path of the currently executing script file, respectively. Sometimes, developers try to use these variables to create paths to other files, such as:

var fullPath = __dirname + "/foo.js";

However, there are a few problems with this. First, you can't be sure what type of system the script is running on. Node.js can be run on any computer, including Windows, which uses a different path separator. It's very easy, therefore, to create an invalid path using string concatenation and assuming Unix-style separators. There's also the possibility of having double separators, or otherwise ending up with an invalid path.

In order to avoid any confusion as to how to create the correct path, Node.js provides the path module. This module uses system-specific information to always return the correct value. So you can rewrite the previous example as:

var fullPath = path.join(__dirname, "foo.js");

This example doesn't need to include separators as path.join() will do it in the most appropriate manner. Alternately, you can use path.resolve() to retrieve the fully-qualified path:

var fullPath = path.resolve(__dirname, "foo.js");

Both path.join() and path.resolve() are suitable replacements for string concatenation wherever file or directory paths are being created.

Rule Details

This rule aims to prevent string concatenation of directory paths in Node.js

Examples of incorrect code for this rule:

/*eslint no-path-concat: "error"*/

var fullPath = __dirname + "/foo.js";

var fullPath = __filename + "/foo.js";

Examples of correct code for this rule:

/*eslint no-path-concat: "error"*/

var fullPath = dirname + "/foo.js";

When Not To Use It

If you want to allow string concatenation of path names. Source: http://eslint.org/docs/rules/

Element (body.main) is overqualified, just use .main without element name.
Open

body.main {
Severity: Minor
Found in src/css/style.css by csslint

Values of 0 shouldn't have units specified.
Open

    padding-left: 0em;
Severity: Minor
Found in src/css/style.css by csslint

Values of 0 shouldn't have units specified.
Open

    margin-top:0px;
Severity: Minor
Found in src/css/style.css by csslint

Values of 0 shouldn't have units specified.
Open

    margin: 1em 0em;
Severity: Minor
Found in src/css/style.css by csslint

Don't use IDs in selectors.
Open

#dlgSettings .global-shortcut kbd {
Severity: Minor
Found in src/css/style.css by csslint

Don't use IDs in selectors.
Open

#dlgSettings .settings-info {
Severity: Minor
Found in src/css/style.css by csslint

Don't use IDs in selectors.
Open

#pSettingsInfo_7 {
Severity: Minor
Found in src/css/style.css by csslint

The property -ms-transform is compatible with -webkit-transform and should be included as well.
Open

  -webkit-transform: rotateZ(45deg);
Severity: Minor
Found in src/css/style.css by csslint

Rule doesn't have all its properties in alphabetical order.
Open

body.main {
Severity: Minor
Found in src/css/style.css by csslint

Rule doesn't have all its properties in alphabetical order.
Open

.empty-notebook {
Severity: Minor
Found in src/css/style.css by csslint
Severity
Category
Status
Source
Language