Sign upLogin

markenwerk/php-slack-client

View on GitHub
Star
src/SlackClient.php

Summary

Maintainability
D
2 days
Test Coverage

Function buildPayload has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    protected function buildPayload($receiver, SlackMessageInterface $slackMessage)
    {
        $payload = array(
            'channel' => $receiver,
            'username' => $this->getUsername(),
Severity: Minor
Found in src/SlackClient.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Missing class import via use statement (line '118', column '14').
Open

            throw new \InvalidArgumentException('Expected the channel name as string. Got ' . $argumentType);
Severity: Minor
Found in src/SlackClient.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '99', column '14').
Open

            throw new \InvalidArgumentException('Expected the username as string. Got ' . $argumentType);
Severity: Minor
Found in src/SlackClient.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '142', column '14').
Open

            throw new \InvalidArgumentException('Expected the channel name as string. Got ' . $argumentType);
Severity: Minor
Found in src/SlackClient.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '121', column '14').
Open

            throw new \InvalidArgumentException('The channel name is invalid. It has to start with "#".');
Severity: Minor
Found in src/SlackClient.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '55', column '14').
Open

            throw new \InvalidArgumentException('Expected the subdomain name as string. Got ' . $argumentType);
Severity: Minor
Found in src/SlackClient.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '77', column '14').
Open

            throw new \InvalidArgumentException('Expected the token as string. Got ' . $argumentType);
Severity: Minor
Found in src/SlackClient.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '145', column '14').
Open

            throw new \InvalidArgumentException('The mamber name is invalid. It has to start with "@".');
Severity: Minor
Found in src/SlackClient.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function postToChannel($channel, SlackMessageInterface $slackMessage)
    {
        if (!is_string($channel)) {
            $argumentType = (is_object($channel)) ? get_class($channel) : gettype($channel);
            throw new \InvalidArgumentException('Expected the channel name as string. Got ' . $argumentType);
Severity: Major
Found in src/SlackClient.php and 1 other location - About 5 hrs to fix
src/SlackClient.php on lines 138..151

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 150.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function postToMember($member, SlackMessageInterface $slackMessage)
    {
        if (!is_string($member)) {
            $argumentType = (is_object($member)) ? get_class($member) : gettype($member);
            throw new \InvalidArgumentException('Expected the channel name as string. Got ' . $argumentType);
Severity: Major
Found in src/SlackClient.php and 1 other location - About 5 hrs to fix
src/SlackClient.php on lines 114..127

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 150.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

    public function setToken($token)
    {
        if (!is_string($token)) {
            $argumentType = (is_object($token)) ? get_class($token) : gettype($token);
            throw new \InvalidArgumentException('Expected the token as string. Got ' . $argumentType);
Severity: Major
Found in src/SlackClient.php and 9 other locations - About 2 hrs to fix
src/SlackAttachment.php on lines 48..56
src/SlackAttachment.php on lines 70..78
src/SlackAttachment.php on lines 171..179
src/SlackAttachment.php on lines 193..201
src/SlackClient.php on lines 51..59
src/SlackClient.php on lines 95..103
src/SlackMessage.php on lines 50..58
src/SlackMessage.php on lines 167..175
src/SlackMessage.php on lines 189..197

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 82.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

    public function setSubdomainName($subdomainName)
    {
        if (!is_string($subdomainName)) {
            $argumentType = (is_object($subdomainName)) ? get_class($subdomainName) : gettype($subdomainName);
            throw new \InvalidArgumentException('Expected the subdomain name as string. Got ' . $argumentType);
Severity: Major
Found in src/SlackClient.php and 9 other locations - About 2 hrs to fix
src/SlackAttachment.php on lines 48..56
src/SlackAttachment.php on lines 70..78
src/SlackAttachment.php on lines 171..179
src/SlackAttachment.php on lines 193..201
src/SlackClient.php on lines 73..81
src/SlackClient.php on lines 95..103
src/SlackMessage.php on lines 50..58
src/SlackMessage.php on lines 167..175
src/SlackMessage.php on lines 189..197

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 82.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

    public function setUsername($username)
    {
        if (!is_string($username)) {
            $argumentType = (is_object($username)) ? get_class($username) : gettype($username);
            throw new \InvalidArgumentException('Expected the username as string. Got ' . $argumentType);
Severity: Major
Found in src/SlackClient.php and 9 other locations - About 2 hrs to fix
src/SlackAttachment.php on lines 48..56
src/SlackAttachment.php on lines 70..78
src/SlackAttachment.php on lines 171..179
src/SlackAttachment.php on lines 193..201
src/SlackClient.php on lines 51..59
src/SlackClient.php on lines 73..81
src/SlackMessage.php on lines 50..58
src/SlackMessage.php on lines 167..175
src/SlackMessage.php on lines 189..197

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 82.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            foreach ($slackMessage->getAttachments() as $attachment) {
                if (!isset($payload['attachments'])) {
                    $payload['attachments'] = array();
                }
                $payload['attachments'][] = $attachment->toArray();
Severity: Minor
Found in src/SlackClient.php and 1 other location - About 30 mins to fix
src/SlackAttachment.php on lines 226..231

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status