Sign upLogin

markenwerk/php-slack-client

View on GitHub
Star
src/SlackMessage.php

Summary

Maintainability
C
1 day
Test Coverage

Missing class import via use statement (line '193', column '14').
Open

            throw new \InvalidArgumentException('Expected the unfurl media setting as boolean. Got ' . $argumentType);
Severity: Minor
Found in src/SlackMessage.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '149', column '14').
Open

            throw new \InvalidArgumentException('The icon URL is invalid.');
Severity: Minor
Found in src/SlackMessage.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '77', column '15').
Open

                throw new \InvalidArgumentException(
Severity: Minor
Found in src/SlackMessage.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '54', column '14').
Open

            throw new \InvalidArgumentException('Expected the text as string. Got ' . $argumentType);
Severity: Minor
Found in src/SlackMessage.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '146', column '14').
Open

            throw new \InvalidArgumentException('Expected the icon URL as string. Got ' . $argumentType);
Severity: Minor
Found in src/SlackMessage.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '171', column '14').
Open

            throw new \InvalidArgumentException('Expected the unfurl links setting as boolean. Got ' . $argumentType);
Severity: Minor
Found in src/SlackMessage.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function removeAttachment(SlackAttachment $attachment)
    {
        $attachmentCount = count($this->attachments);
        for ($i = 0; $i < $attachmentCount; $i++) {
            if ($this->attachments[$i] == $attachment) {
Severity: Major
Found in src/SlackMessage.php and 1 other location - About 2 hrs to fix
src/SlackAttachment.php on lines 121..132

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 93.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function setAttachments(array $attachments)
    {
        foreach ($attachments as $attachment) {
            if (!$attachment instanceof SlackAttachmentInterface) {
                $argumentType = (is_object($attachment)) ? get_class($attachment) : gettype($attachment);
Severity: Major
Found in src/SlackMessage.php and 1 other location - About 2 hrs to fix
src/SlackAttachment.php on lines 92..105

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 86.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

    public function setText($text)
    {
        if (!is_string($text)) {
            $argumentType = (is_object($text)) ? get_class($text) : gettype($text);
            throw new \InvalidArgumentException('Expected the text as string. Got ' . $argumentType);
Severity: Major
Found in src/SlackMessage.php and 9 other locations - About 2 hrs to fix
src/SlackAttachment.php on lines 48..56
src/SlackAttachment.php on lines 70..78
src/SlackAttachment.php on lines 171..179
src/SlackAttachment.php on lines 193..201
src/SlackClient.php on lines 51..59
src/SlackClient.php on lines 73..81
src/SlackClient.php on lines 95..103
src/SlackMessage.php on lines 167..175
src/SlackMessage.php on lines 189..197

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 82.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

    public function setUnfurlMedia($unfurlMedia)
    {
        if (!is_bool($unfurlMedia)) {
            $argumentType = (is_object($unfurlMedia)) ? get_class($unfurlMedia) : gettype($unfurlMedia);
            throw new \InvalidArgumentException('Expected the unfurl media setting as boolean. Got ' . $argumentType);
Severity: Major
Found in src/SlackMessage.php and 9 other locations - About 2 hrs to fix
src/SlackAttachment.php on lines 48..56
src/SlackAttachment.php on lines 70..78
src/SlackAttachment.php on lines 171..179
src/SlackAttachment.php on lines 193..201
src/SlackClient.php on lines 51..59
src/SlackClient.php on lines 73..81
src/SlackClient.php on lines 95..103
src/SlackMessage.php on lines 50..58
src/SlackMessage.php on lines 167..175

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 82.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

    public function setUnfurlLinks($unfurlLinks)
    {
        if (!is_bool($unfurlLinks)) {
            $argumentType = (is_object($unfurlLinks)) ? get_class($unfurlLinks) : gettype($unfurlLinks);
            throw new \InvalidArgumentException('Expected the unfurl links setting as boolean. Got ' . $argumentType);
Severity: Major
Found in src/SlackMessage.php and 9 other locations - About 2 hrs to fix
src/SlackAttachment.php on lines 48..56
src/SlackAttachment.php on lines 70..78
src/SlackAttachment.php on lines 171..179
src/SlackAttachment.php on lines 193..201
src/SlackClient.php on lines 51..59
src/SlackClient.php on lines 73..81
src/SlackClient.php on lines 95..103
src/SlackMessage.php on lines 50..58
src/SlackMessage.php on lines 189..197

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 82.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

The 'getUnfurlLinks()' method which returns a boolean should be named 'is...()' or 'has...()'
Open

    public function getUnfurlLinks()
    {
        return $this->unfurlLinks;
    }
Severity: Minor
Found in src/SlackMessage.php by phpmd

BooleanGetMethodName

Since: 0.2

Looks for methods named 'getX()' with 'boolean' as the return type. The convention is to name these methods 'isX()' or 'hasX()'.

Example

class Foo {
    /**
     * @return boolean
     */
    public function getFoo() {} // bad
    /**
     * @return bool
     */
    public function isFoo(); // ok
    /**
     * @return boolean
     */
    public function getFoo($bar); // ok, unless checkParameterizedMethods=true
}

Source https://phpmd.org/rules/naming.html#booleangetmethodname

The 'getUnfurlMedia()' method which returns a boolean should be named 'is...()' or 'has...()'
Open

    public function getUnfurlMedia()
    {
        return $this->unfurlMedia;
    }
Severity: Minor
Found in src/SlackMessage.php by phpmd

BooleanGetMethodName

Since: 0.2

Looks for methods named 'getX()' with 'boolean' as the return type. The convention is to name these methods 'isX()' or 'hasX()'.

Example

class Foo {
    /**
     * @return boolean
     */
    public function getFoo() {} // bad
    /**
     * @return bool
     */
    public function isFoo(); // ok
    /**
     * @return boolean
     */
    public function getFoo($bar); // ok, unless checkParameterizedMethods=true
}

Source https://phpmd.org/rules/naming.html#booleangetmethodname

There are no issues that match your filters.

Category
Status