Sign upLogin

markrickert/motion-csv

View on GitHub
Star

Showing 40 of 40 total issues

Method set_mode_from_integer has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def set_mode_from_integer(mode)
      @readable = @writable = @append = false

      case mode & (IO::RDONLY | IO::WRONLY | IO::RDWR)
      when IO::RDONLY
Severity: Minor
Found in lib/motion-csv/stringio.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method << has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def <<(row)
      @lines += 1
      if !row.is_a?(Row)
        row = Row.new(self, row, @lines)
      end
Severity: Minor
Found in lib/motion-csv/motion-csv.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method convread has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def convread(file, quot = '"', sep = ',', fail_on_malformed = true, column = NumericConversion.new, &block)
Severity: Minor
Found in lib/motion-csv/motion-csv.rb - About 45 mins to fix

    Method ungetbyte has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

      def ungetbyte(bytes)
    raise(IOError, "not opened for reading") unless @readable
    return nil if bytes == nil

    bytes = bytes.chr if bytes.kind_of?(Fixnum)
    Severity: Minor
    Found in lib/motion-csv/stringio.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method parse has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def parse(io, quot = '"', sep = ',', fail_on_malformed = true, column = NoConversion.new, &block)
    Severity: Minor
    Found in lib/motion-csv/motion-csv.rb - About 45 mins to fix

      Method out has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def out(data, mode = 'w', quot = '"', sep = ',', quotenum = false, &block)
      Severity: Minor
      Found in lib/motion-csv/motion-csv.rb - About 45 mins to fix

        Method read has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def read(file, quot = '"', sep = ',', fail_on_malformed = true, column = NoConversion.new, &block)
        Severity: Minor
        Found in lib/motion-csv/motion-csv.rb - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                    table << row unless row.empty?
          Severity: Major
          Found in lib/motion-csv/motion-csv.rb - About 45 mins to fix

            Method parse_headers has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                def parse_headers(data, quot = '"', sep = ',', fail_on_malformed = true, column = NoConversion.new, &block)
            Severity: Minor
            Found in lib/motion-csv/motion-csv.rb - About 45 mins to fix

              Method headers has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  def headers(file, quot = '"', sep = ',', fail_on_malformed = true, column = NoConversion.new, &block)
              Severity: Minor
              Found in lib/motion-csv/motion-csv.rb - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                          row << column.convert(false) unless column.empty? && endline
                Severity: Major
                Found in lib/motion-csv/motion-csv.rb - About 45 mins to fix

                  Method ungetc has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                  Open

                    def ungetc(chars)
    raise(IOError, "not opened for reading") unless @readable
    return nil if chars == nil

    chars = chars.chr if chars.kind_of?(Fixnum)
                  Severity: Minor
                  Found in lib/motion-csv/stringio.rb - About 45 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method write has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      def write(data, quot = '"', sep = ',', quotenum = false, &block)
                  Severity: Minor
                  Found in lib/motion-csv/motion-csv.rb - About 35 mins to fix

                    Method append has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        def append(data, quot = '"', sep = ',', quotenum = false, &block)
                    Severity: Minor
                    Found in lib/motion-csv/motion-csv.rb - About 35 mins to fix

                      Method truncate has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                      Open

                        def truncate(len)
    raise(IOError, "closing non-duplex IO for writing") unless @writable
    raise(TypeError) unless len.respond_to?(:to_int)
    length = len.to_int
    raise(Errno::EINVAL, "negative length") if (length < 0)
                      Severity: Minor
                      Found in lib/motion-csv/stringio.rb - About 35 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method << has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                      Open

                          def <<(ch)
      if ch == ?-.ord
        @float = @int = size == 0
      elsif (ch > ?9.ord || ch < ?0.ord) && ch != ?..ord
        @int = @float = false
                      Severity: Minor
                      Found in lib/motion-csv/motion-csv.rb - About 35 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method define_mode has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                          def define_mode(mode=nil)
      if mode == nil
        # default modes
        @string.frozen? ? set_mode_from_string("r") : set_mode_from_string("r+")
      elsif mode.is_a?(Integer)
                      Severity: Minor
                      Found in lib/motion-csv/stringio.rb - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method print has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                        def print(*args)
    raise IOError, "not opened for writing" unless @writable
    args << $_ if args.empty?
    args.map! { |x| (x == nil) ? "nil" : x }
    write((args << $\).flatten.join)
                      Severity: Minor
                      Found in lib/motion-csv/stringio.rb - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          def read(file, quot = '"', sep = ',', fail_on_malformed = true, column = NoConversion.new, &block)
      File.open(file, 'r') do |io|
        parse(io, quot, sep, fail_on_malformed, column, &block)
                      Severity: Minor
                      Found in lib/motion-csv/motion-csv.rb and 1 other location - About 15 mins to fix
                      lib/motion-csv/motion-csv.rb on lines 304..306

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 25.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          def convread(file, quot = '"', sep = ',', fail_on_malformed = true, column = NumericConversion.new, &block)
      File.open(file, 'r') do |io|
        parse(io, quot, sep, fail_on_malformed, column, &block)
                      Severity: Minor
                      Found in lib/motion-csv/motion-csv.rb and 1 other location - About 15 mins to fix
                      lib/motion-csv/motion-csv.rb on lines 298..300

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 25.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Severity
                      Category
                      Status
                      Source
                      Language