Sign upLogin

marksmall/node-build-web-app

View on GitHub
Star
src/gulp/tasks/html.js

Summary

Maintainability
B
5 hrs
Test Coverage

Function registerTask has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    registerTask(gulp){
        super.registerTask(gulp);

        gulp.task("html", "Optimize HTML", () =>{
            // Determine if the inlined scripts should be minified or not
Severity: Minor
Found in src/gulp/tasks/html.js - About 1 hr to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            if(gulp.options.folders){
                src = [ gulp.options.folders.app + config.globs.html ];
            } else{
                src = config.html.src;
            }
Severity: Major
Found in src/gulp/tasks/html.js and 1 other location - About 1 hr to fix
src/gulp/tasks/images.js on lines 21..25

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 67.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

            if(typeof gulp.options.minifyProductionHTML !== "undefined"){
                minifyProductionHTML = gulp.options.minifyProductionHTML;

                if(minifyProductionHTML === false){
                    gutil.log("The HTML will NOT be minified!");
Severity: Major
Found in src/gulp/tasks/html.js and 4 other locations - About 1 hr to fix
src/gulp/tasks/html.js on lines 24..30
src/gulp/tasks/scripts-javascript-dist.js on lines 24..30
src/gulp/tasks/scripts-javascript-dist.js on lines 35..41
src/gulp/tasks/scripts-javascript-dist.js on lines 46..52

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

            if(typeof gulp.options.minifyProductionJSBundle !== "undefined"){
                minifyInlinedScripts = gulp.options.minifyProductionJSBundle;

                if(minifyInlinedScripts === false){
                    gutil.log("The inlined scripts will NOT be minified!");
Severity: Major
Found in src/gulp/tasks/html.js and 4 other locations - About 1 hr to fix
src/gulp/tasks/html.js on lines 35..41
src/gulp/tasks/scripts-javascript-dist.js on lines 24..30
src/gulp/tasks/scripts-javascript-dist.js on lines 35..41
src/gulp/tasks/scripts-javascript-dist.js on lines 46..52

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Parsing error: 'import' and 'export' may appear only with 'sourceType: module'
Open

import AbstractTaskLoader from "../abstractTaskLoader";
Severity: Minor
Found in src/gulp/tasks/html.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

There are no issues that match your filters.

Category
Status