Sign upLogin

marksmall/node-build-web-app

View on GitHub
Star

Showing 68 of 68 total issues

Function registerTask has 114 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    registerTask(gulp){
        super.registerTask(gulp);

        runSequence = runSequence.use(gulp); // needed to bind to the correct gulp object (alternative is to pass gulp to runSequence as first argument)
Severity: Major
Found in src/gulp/tasks/serve.js - About 4 hrs to fix

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        if(gulp.options.proxy){
            proxy = proxyMiddleware(gulp.options.proxy.api, {
                target: gulp.options.proxy.target + ":" + gulp.options.proxy.port,
                changeOrigin: true   // for vhosted sites, changes host header to match to target's host
            });
Severity: Major
Found in src/gulp/tasks/serve-dist.js and 1 other location - About 2 hrs to fix
src/gulp/tasks/serve.js on lines 58..65

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 84.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        if(gulp.options.proxy){
            proxy = proxyMiddleware(gulp.options.proxy.api, {
                target: gulp.options.proxy.target + ":" + gulp.options.proxy.port,
                changeOrigin: true   // for vhosted sites, changes host header to match to target's host
            });
Severity: Major
Found in src/gulp/tasks/serve.js and 1 other location - About 2 hrs to fix
src/gulp/tasks/serve-dist.js on lines 33..40

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 84.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function registerTask has 59 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    registerTask(gulp){
        super.registerTask(gulp);

        gulp.task("scripts-javascript-dist", "Package all JavaScript code for production", () =>{
            // Assuming that all TS and ES2015 code has already been converted to ES5 using the System module type
Severity: Major
Found in src/gulp/tasks/scripts-javascript-dist.js - About 2 hrs to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

let getTypeScriptFolder = (gulp, config) =>{
    if(gulp.options.folders){
        return [ gulp.options.folders.app + config.globs.scripts.javascript ];
    } else{
        return config.javascript.src;
Severity: Major
Found in src/gulp/utils.js and 1 other location - About 2 hrs to fix
src/gulp/utils.js on lines 177..183

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 77.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

let getJavaScriptFolder = (gulp, config) =>{
    if(gulp.options.folders){
        return [ gulp.options.folders.app + config.globs.scripts.javascript ];
    } else{
        return config.javascript.src;
Severity: Major
Found in src/gulp/utils.js and 1 other location - About 2 hrs to fix
src/gulp/utils.js on lines 185..191

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 77.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function registerTask has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    registerTask(gulp){
        super.registerTask(gulp);

        gulp.task("html", "Optimize HTML", () =>{
            // Determine if the inlined scripts should be minified or not
Severity: Minor
Found in src/gulp/tasks/html.js - About 1 hr to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            if(gulp.options.folders){
                src = [ gulp.options.folders.app + config.globs.html ];
            } else{
                src = config.html.src;
            }
Severity: Major
Found in src/gulp/tasks/html.js and 1 other location - About 1 hr to fix
src/gulp/tasks/images.js on lines 21..25

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 67.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            if(gulp.options.folders){
                src = [ gulp.options.folders.app + config.globs.images ];
            } else{
                src = config.images.src;
            }
Severity: Major
Found in src/gulp/tasks/images.js and 1 other location - About 1 hr to fix
src/gulp/tasks/html.js on lines 46..50

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 67.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function registerTask has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    registerTask(gulp){
        super.registerTask(gulp);

        let run = runSequence.use(gulp); // needed to bind to the correct gulp object (alternative is to pass gulp to runSequence as first argument)
Severity: Minor
Found in src/gulp/tasks/serve-dist.js - About 1 hr to fix

Similar blocks of code found in 5 locations. Consider refactoring.
Open

            if(typeof gulp.options.minifyProductionJSBundle !== "undefined"){
                minifyProductionJSBundle = gulp.options.minifyProductionJSBundle;

                if(minifyProductionJSBundle === false){
                    gutil.log("The production JS bundle will NOT be minified!");
Severity: Major
Found in src/gulp/tasks/scripts-javascript-dist.js and 4 other locations - About 1 hr to fix
src/gulp/tasks/html.js on lines 24..30
src/gulp/tasks/html.js on lines 35..41
src/gulp/tasks/scripts-javascript-dist.js on lines 35..41
src/gulp/tasks/scripts-javascript-dist.js on lines 46..52

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

            if(typeof gulp.options.useJSPM !== "undefined"){
                useJSPM = gulp.options.useJSPM;

                if(useJSPM === false){
                    gutil.log("The production JS bundle will be built using SystemJS-builder rather than with JSPM!");
Severity: Major
Found in src/gulp/tasks/scripts-javascript-dist.js and 4 other locations - About 1 hr to fix
src/gulp/tasks/html.js on lines 24..30
src/gulp/tasks/html.js on lines 35..41
src/gulp/tasks/scripts-javascript-dist.js on lines 24..30
src/gulp/tasks/scripts-javascript-dist.js on lines 35..41

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

            if(typeof gulp.options.minifyProductionHTML !== "undefined"){
                minifyProductionHTML = gulp.options.minifyProductionHTML;

                if(minifyProductionHTML === false){
                    gutil.log("The HTML will NOT be minified!");
Severity: Major
Found in src/gulp/tasks/html.js and 4 other locations - About 1 hr to fix
src/gulp/tasks/html.js on lines 24..30
src/gulp/tasks/scripts-javascript-dist.js on lines 24..30
src/gulp/tasks/scripts-javascript-dist.js on lines 35..41
src/gulp/tasks/scripts-javascript-dist.js on lines 46..52

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

            if(typeof gulp.options.mangleProductionJSBundle !== "undefined"){
                mangleProductionJSBundle = gulp.options.mangleProductionJSBundle;

                if(mangleProductionJSBundle === false){
                    gutil.log("The production JS bundle will NOT be mangled!");
Severity: Major
Found in src/gulp/tasks/scripts-javascript-dist.js and 4 other locations - About 1 hr to fix
src/gulp/tasks/html.js on lines 24..30
src/gulp/tasks/html.js on lines 35..41
src/gulp/tasks/scripts-javascript-dist.js on lines 24..30
src/gulp/tasks/scripts-javascript-dist.js on lines 46..52

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

            if(typeof gulp.options.minifyProductionJSBundle !== "undefined"){
                minifyInlinedScripts = gulp.options.minifyProductionJSBundle;

                if(minifyInlinedScripts === false){
                    gutil.log("The inlined scripts will NOT be minified!");
Severity: Major
Found in src/gulp/tasks/html.js and 4 other locations - About 1 hr to fix
src/gulp/tasks/html.js on lines 35..41
src/gulp/tasks/scripts-javascript-dist.js on lines 24..30
src/gulp/tasks/scripts-javascript-dist.js on lines 35..41
src/gulp/tasks/scripts-javascript-dist.js on lines 46..52

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function exports has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = (config) =>{
    config.set({

        // base path that will be used to resolve all patterns (eg. files, exclude)
        //basePath: ".tmp/",
Severity: Minor
Found in karma.conf.js - About 1 hr to fix

Function registerTask has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    registerTask(gulp){
        super.registerTask(gulp);

        gulp.task("styles-dist", "Optimize and minimize stylesheets for production", () =>{
            // If the app src folder is overridden, then append it to the watch list, otherwise use default.
Severity: Minor
Found in src/gulp/tasks/styles-dist.js - About 1 hr to fix

Identical blocks of code found in 2 locations. Consider refactoring.
Open

let filterEmptyDirectories = function(es){
    return es.map((file, cb) =>{
        if(file.stat.isFile()){
            return cb(null, file);
        } else{
Severity: Major
Found in gulp/utils.js and 1 other location - About 1 hr to fix
src/gulp/utils.js on lines 76..84

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 58.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

let filterEmptyDirectories = es =>{
    return es.map((file, cb) =>{
        if(file.stat.isFile()){
            return cb(null, file);
        } else{
Severity: Major
Found in src/gulp/utils.js and 1 other location - About 1 hr to fix
gulp/utils.js on lines 74..82

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 58.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function registerTask has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    registerTask(gulp){
        super.registerTask(gulp);

        gulp.task("styles", "Compile, add vendor prefixes and generate sourcemaps", () =>{
            // If the app src folder is overridden, then append it to the watch list, otherwise use default.
Severity: Minor
Found in src/gulp/tasks/styles.js - About 1 hr to fix
Severity
Category
Status
Source
Language