Sign upLogin

markusressel/keel-telegram-bot

View on GitHub
Star
keel_telegram_bot/api_client.py

Summary

Maintainability
A
2 hrs
Test Coverage

Function _create_request_url has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    def _create_request_url(url: str, params: dict = None):
        """
        Adds query params to the given url

        :param url: the url to extend
Severity: Minor
Found in keel_telegram_bot/api_client.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def __init__(self, host: str, port: int, ssl: bool, user: str, password: str):
Severity: Minor
Found in keel_telegram_bot/api_client.py - About 35 mins to fix

    Function _do_request has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def _do_request(self, method: str = GET, url: str = "/", params: dict = None,
                    json: dict = None) -> list or dict or None:
        """
        Executes a http request based on the given parameters
    Severity: Minor
    Found in keel_telegram_bot/api_client.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status