Sign upLogin

martin-helmich/prometheus-nginxlog-exporter

View on GitHub
Star
pkg/relabeling/mapping.go
8d9b0c2d

Summary

Maintainability
A
2 hrs
Test Coverage

Method Relabeling.Map has a Cognitive Complexity of 31 (exceeds 20 allowed). Consider refactoring.
Open

func (r *Relabeling) Map(sourceValue string) (string, error) {
    if r.Split > 0 {
        separator := r.Separator
        if separator == "" {
            separator = " "
Severity: Minor
Found in pkg/relabeling/mapping.go - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Relabeling.Map has 5 return statements (exceeds 4 allowed).
Open

func (r *Relabeling) Map(sourceValue string) (string, error) {
    if r.Split > 0 {
        separator := r.Separator
        if separator == "" {
            separator = " "
Severity: Major
Found in pkg/relabeling/mapping.go - About 35 mins to fix

    There are no issues that match your filters.

    Category
    Status