Sign upLogin

martin-helmich/typo3-typoscript-parser

View on GitHub
Star
src/Parser/Printer/PrettyPrinter.php

Summary

Maintainability
A
3 hrs
Test Coverage
A
96%

Showing 92 of 92 total issues

Method printStatementList has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function printStatementList(array $statements, OutputInterface $output, int $nesting = 0): void
    {
        if ($nesting === 0) {
            $statements = $this->trimTrailingNoops($statements);
        }
Severity: Minor
Found in src/Parser/Printer/PrettyPrinter.php - About 1 hr to fix

    Function printStatementList has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        private function printStatementList(array $statements, OutputInterface $output, int $nesting = 0): void
        {
            if ($nesting === 0) {
                $statements = $this->trimTrailingNoops($statements);
            }
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php - About 1 hr to fix

    The method printStatementList() has a Cyclomatic Complexity of 14. The configured cyclomatic complexity threshold is 10.
    Open

        private function printStatementList(array $statements, OutputInterface $output, int $nesting = 0): void
        {
            if ($nesting === 0) {
                $statements = $this->trimTrailingNoops($statements);
            }
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpmd

    The class PrettyPrinter has a coupling between objects value of 19. Consider to reduce the number of dependencies under 13.
    Open

    class PrettyPrinter implements ASTPrinterInterface
    {
        private PrettyPrinterConfiguration $prettyPrinterConfiguration;
     
        public function __construct(?PrettyPrinterConfiguration $prettyPrinterConfiguration = null)
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpmd

    Avoid using static access to class 'Helmich\TypoScriptParser\Parser\Printer\PrettyPrinterConfiguration' in method '__construct'.
    Open

            $this->prettyPrinterConfiguration = $prettyPrinterConfiguration ?? PrettyPrinterConfiguration::create();
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpmd

    Avoid using Helmich\TypoScriptParser\Parser\Printer\count() function in while loops.
    Open

            while (count($out) && $out[count($out) - 1] instanceof NopStatement) {
                array_pop($out);
            }
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpmd

    Avoid using Helmich\TypoScriptParser\Parser\Printer\count() function in while loops.
    Open

            while (count($out) && $out[count($out) - 1] instanceof NopStatement) {
                array_pop($out);
            }
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpmd

    A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 35 and the first side effect is on line 31.
    Open

    <?php
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Possible parse error: class missing opening or closing brace
    Open

    class PrettyPrinter implements ASTPrinterInterface
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    DEFAULT statements must be defined using a colon
    Open

                        default => "[end]",
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Possible parse error: class missing opening or closing brace
    Open

    class PrettyPrinter implements ASTPrinterInterface
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 4 spaces, found 8
    Open

            if ($nesting === 0) {
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 12
    Open

                } elseif ($statement instanceof MultilineComment) {
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 0 spaces, found 4
    Open

        }
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 0 spaces, found 4
    Open

        private function getIndent(int $nesting): string
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 4 spaces, found 8
    Open

            if ($operator instanceof Copy) {
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 12
    Open

                if ($statement->condition !== null) {
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 0 spaces, found 4
    Open

        }
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 12
    Open

                } elseif ($statement instanceof Delete) {
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 0 spaces, found 4
    Open

        private function printNestedAssignment(OutputInterface $output, int $nesting, NestedAssignment $statement): void
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 4 spaces, found 8
    Open

            }
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 0 spaces, found 4
    Open

        }
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 4 spaces, found 8
    Open

            switch ($this->prettyPrinterConfiguration->getConditionTermination()) {
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 0 spaces, found 4
    Open

        }
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 4 spaces, found 8
    Open

            if ($statement->newSyntax) {
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 0 spaces, found 4
    Open

        private function printAssignment(OutputInterface $output, Assignment $statement, string $indent): void
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 12
    Open

                case PrettyPrinterConditionTermination::EnforceGlobal:
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 12
    Open

                }
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 4 spaces, found 8
    Open

            if ($this->closeCondition($hasNext)) {
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 0 spaces, found 4
    Open

        }
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 0 spaces, found 4
    Open

        private PrettyPrinterConfiguration $prettyPrinterConfiguration;
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 0 spaces, found 4
    Open

        public function __construct(?PrettyPrinterConfiguration $prettyPrinterConfiguration = null)
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 12
    Open

                } elseif ($statement instanceof Assignment) {
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 4 spaces, found 8
    Open

            }
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 0 spaces, found 4
    Open

        }
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 12
    Open

                }
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 0 spaces, found 4
    Open

        }
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 12
    Open

                if ($statement instanceof NestedAssignment) {
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 12
    Open

                } elseif ($statement instanceof BinaryObjectOperator) {
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 12
    Open

                } elseif ($statement instanceof ConditionalStatement) {
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 0 spaces, found 4
    Open

        private function printBinaryObjectOperator(OutputInterface $output, BinaryObjectOperator $operator, int $nesting): void
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 0 spaces, found 4
    Open

        }
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 4 spaces, found 8
    Open

            if (str_contains($statement->value->value, "\n")) {
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 4 spaces, found 8
    Open

            while (count($out) && $out[count($out) - 1] instanceof NopStatement) {
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 4 spaces, found 8
    Open

            }
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 0 spaces, found 4
    Open

        private function printFileIncludeStatement(OutputInterface $output, FileIncludeStatement $statement): void
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 4 spaces, found 8
    Open

            if ($statement->condition !== null) {
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 0 spaces, found 4
    Open

        private function trimTrailingNoops(array $statements): array
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 4 spaces, found 8
    Open

            } elseif ($operator instanceof Reference) {
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 4 spaces, found 8
    Open

            if ($statement instanceof FileIncludeStatement) {
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 4 spaces, found 8
    Open

            }
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 4 spaces, found 8
    Open

            if ($this->prettyPrinterConfiguration->shouldIndentConditions()) {
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 0 spaces, found 4
    Open

        private function printNopStatement(OutputInterface $output): void
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 0 spaces, found 4
    Open

        }
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 0 spaces, found 4
    Open

        private function closeCondition(bool $hasNext): bool
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 12
    Open

                case PrettyPrinterConditionTermination::Keep:
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 4 spaces, found 8
    Open

            }
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 12
    Open

                } elseif ($statement instanceof IncludeStatement) {
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 4 spaces, found 8
    Open

            }
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 12
    Open

                } elseif ($statement instanceof Modification) {
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 0 spaces, found 4
    Open

        }
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 0 spaces, found 4
    Open

        }
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 0 spaces, found 4
    Open

        }
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 20
    Open

                        default => "[end]",
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Closing brace indented incorrectly; expected 4 spaces, found 0
    Open

    }
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 12
    Open

                } elseif ($statement instanceof Comment) {
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 12
    Open

                } elseif ($statement instanceof NopStatement) {
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 4 spaces, found 8
    Open

            } elseif ($statement instanceof DirectoryIncludeStatement) {
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 4 spaces, found 8
    Open

            } else {
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 4 spaces, found 8
    Open

            }
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 4 spaces, found 8
    Open

            }
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Closing brace indented incorrectly; expected 8 spaces, found 4
    Open

        }
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 0 spaces, found 4
    Open

        public function printStatements(array $statements, OutputInterface $output): void
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 4 spaces, found 8
    Open

            for ($i = 0; $i < $count; $i++) {
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 4 spaces, found 8
    Open

            if ($statement->extensions !== null && $statement->extensions !== "") {
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 0 spaces, found 4
    Open

        public function setPrettyPrinterConfiguration(PrettyPrinterConfiguration $prettyPrinterConfiguration): void
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 4 spaces, found 8
    Open

            }
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 0 spaces, found 4
    Open

        }
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 0 spaces, found 4
    Open

        private function printStatementList(array $statements, OutputInterface $output, int $nesting = 0): void
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 0 spaces, found 4
    Open

        private function printIncludeStatement(OutputInterface $output, IncludeStatement $statement): void
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 0 spaces, found 4
    Open

        private function printDirectoryIncludeStatement(OutputInterface $output, DirectoryIncludeStatement $statement): void
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 0 spaces, found 4
    Open

        private function printConditionalStatement(OutputInterface $output, int $nesting, ConditionalStatement $statement, bool $hasNext = false): void
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 4 spaces, found 8
    Open

            }
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 0 spaces, found 4
    Open

        private function getConditionTerminatorStatement(ConditionalStatement $stmt): string
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Space before opening parenthesis of function call prohibited
    Open

                    return match ($stmt->terminator) {
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 0 spaces, found 4
    Open

        }
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 4 spaces, found 8
    Open

            }
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 4 spaces, found 8
    Open

            }
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 4 spaces, found 8
    Open

            }
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 4 spaces, found 8
    Open

            if (count($statement->elseStatements) > 0) {
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 0 spaces, found 4
    Open

        }
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer

    Line indented incorrectly; expected 4 spaces, found 8
    Open

            if ($this->prettyPrinterConfiguration->shouldIncludeEmptyLineBreaks()) {
    Severity: Minor
    Found in src/Parser/Printer/PrettyPrinter.php by phpcodesniffer
    Category
    Status