Sign upLogin

martinchristen/pyRT

View on GitHub
Star
pyrt/renderer/rgbimage.py

Summary

Maintainability
C
1 day
Test Coverage

File rgbimage.py has 280 lines of code (exceeds 250 allowed). Consider refactoring.
Open

from ..math import Vec2, Vec3
import random
from time import time
from time import sleep
from typing import Type
Severity: Minor
Found in pyrt/renderer/rgbimage.py - About 2 hrs to fix

    Cyclomatic complexity is too high in method update. (8)
    Open

        def update(self, myid="pyrtfb", fps=0):
        t0 = time()
        if RGBImage_has_ipython and RBGImage_has_pillow:
            if RGBImage_use_numpy_array:
                im = Image.fromarray(self.data)
    Severity: Minor
    Found in pyrt/renderer/rgbimage.py by radon

    Cyclomatic Complexity

    Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

    Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

    Construct Effect on CC Reasoning
    if +1 An if statement is a single decision.
    elif +1 The elif statement adds another decision.
    else +0 The else statement does not cause a new decision. The decision is at the if.
    for +1 There is a decision at the start of the loop.
    while +1 There is a decision at the while statement.
    except +1 Each except branch adds a new conditional path of execution.
    finally +0 The finally block is unconditionally executed.
    with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
    assert +1 The assert statement internally roughly equals a conditional statement.
    Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
    Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

    Source: http://radon.readthedocs.org/en/latest/intro.html

    Cyclomatic complexity is too high in method drawLine. (8)
    Open

        def drawLine(self, start: Vec2, end: Vec2, color: Vec3 = Vec3(1.,1.,1.), size : int = 1) -> None:
        """Bresenham's line algorithm
           modified from: https://rosettacode.org/wiki/Bitmap/Bresenham%27s_line_algorithm#Python
        """
        dx = abs(end.x - start.x)
    Severity: Minor
    Found in pyrt/renderer/rgbimage.py by radon

    Cyclomatic Complexity

    Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

    Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

    Construct Effect on CC Reasoning
    if +1 An if statement is a single decision.
    elif +1 The elif statement adds another decision.
    else +0 The else statement does not cause a new decision. The decision is at the if.
    for +1 There is a decision at the start of the loop.
    while +1 There is a decision at the while statement.
    except +1 Each except branch adds a new conditional path of execution.
    finally +0 The finally block is unconditionally executed.
    with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
    assert +1 The assert statement internally roughly equals a conditional statement.
    Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
    Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

    Source: http://radon.readthedocs.org/en/latest/intro.html

    Function update has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

        def update(self, myid="pyrtfb", fps=0):
        t0 = time()
        if RGBImage_has_ipython and RBGImage_has_pillow:
            if RGBImage_use_numpy_array:
                im = Image.fromarray(self.data)
    Severity: Minor
    Found in pyrt/renderer/rgbimage.py - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Cyclomatic complexity is too high in method drawPixel. (6)
    Open

        def drawPixel(self, pos: Vec2, color: Vec3) -> None:
        """
        This code is really slow if you write many pixels - it even contains a bounds check.
        If you draw many points, consider using self.data directly.
    Severity: Minor
    Found in pyrt/renderer/rgbimage.py by radon

    Cyclomatic Complexity

    Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

    Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

    Construct Effect on CC Reasoning
    if +1 An if statement is a single decision.
    elif +1 The elif statement adds another decision.
    else +0 The else statement does not cause a new decision. The decision is at the if.
    for +1 There is a decision at the start of the loop.
    while +1 There is a decision at the while statement.
    except +1 Each except branch adds a new conditional path of execution.
    finally +0 The finally block is unconditionally executed.
    with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
    assert +1 The assert statement internally roughly equals a conditional statement.
    Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
    Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

    Source: http://radon.readthedocs.org/en/latest/intro.html

    Function drawLine has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        def drawLine(self, start: Vec2, end: Vec2, color: Vec3 = Vec3(1.,1.,1.), size : int = 1) -> None:
        """Bresenham's line algorithm
           modified from: https://rosettacode.org/wiki/Bitmap/Bresenham%27s_line_algorithm#Python
        """
        dx = abs(end.x - start.x)
    Severity: Minor
    Found in pyrt/renderer/rgbimage.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function drawPixelFast8 has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def drawPixelFast8(self, x: int, y: int, r: int, g: int, b: int) -> None:
    Severity: Minor
    Found in pyrt/renderer/rgbimage.py - About 35 mins to fix

      Function drawCircleFilled has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def drawCircleFilled(self, center: Vec2, radius: int, color: Vec3, fillcolor: Vec3, size : int = 1):
      Severity: Minor
      Found in pyrt/renderer/rgbimage.py - About 35 mins to fix

        Function clear has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            def clear(self, color: Vec3) -> None:
        """
        Clear Image with specified color
        """
        r = int(color[0]*255.)
        Severity: Minor
        Found in pyrt/renderer/rgbimage.py - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function framebuffer has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            def framebuffer(self, myid="pyrtfb"):
        t0 = time()
        if RGBImage_has_ipython and RBGImage_has_pillow:
            if RGBImage_use_numpy_array:
                im = Image.fromarray(self.data)
        Severity: Minor
        Found in pyrt/renderer/rgbimage.py - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function _repr_html_ has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def _repr_html_(self):
        if RGBImage_has_ipython and RBGImage_has_pillow:
            if RGBImage_use_numpy_array:
                im = Image.fromarray(self.data)
            else:
        Severity: Minor
        Found in pyrt/renderer/rgbimage.py - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        TODO found
        Open

                # TODO: use arbitrary size, currently only size 1,2 and 3 are supported...
        Severity: Minor
        Found in pyrt/renderer/rgbimage.py by fixme

        There are no issues that match your filters.

        Category
        Status