Sign upLogin

martinheidegger/i18n-core

View on GitHub
Star

Showing 46 of 46 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

test('Simple parameter replacement', function (t) {
  t.equals(render('hello {{x}}', {x: 'world'}), 'hello world')
  t.equals(render('hello {{x}}', {x: '<world>'}), 'hello &lt;world&gt;')
  t.end()
})
Severity: Major
Found in test/mustacheSimple.js and 1 other location - About 1 hr to fix
test/mustacheSimple.js on lines 11..15

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 70.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function absN has 14 arguments (exceeds 4 allowed). Consider refactoring.
Open

  api.absN = function absN (singular, plural, count, namedValues, a, b, c, d, e, f, g, h, i, j) {
Severity: Major
Found in simple.js - About 1 hr to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

test('args without placeholder', function (t) {
  t.equals(i18n({'en': {a: ''}}).section('en').__('a', 'e'), '')
  t.end()
})
Severity: Major
Found in test/singular.js and 1 other location - About 1 hr to fix
test/singular.js on lines 12..15

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 69.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

test('args testing', function (t) {
  t.equals(i18n({'en': {a: '%s'}}).section('en').__('a', 'e'), 'e')
  t.end()
})
Severity: Major
Found in test/singular.js and 1 other location - About 1 hr to fix
test/singular.js on lines 17..20

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 69.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function _____n has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function _____n (node, singular, plural, count, namedValues, args) {
  var keys
  var fallbackKey
  if (count > 1) {
    if (typeof plural === 'object' && plural !== null) {
Severity: Minor
Found in simple.js - About 1 hr to fix

Function ___ has 13 arguments (exceeds 4 allowed). Consider refactoring.
Open

function ___ (node, key, namedValues, a, b, c, d, e, f, g, h, i, j) {
Severity: Major
Found in simple.js - About 1 hr to fix

Function i18nChain has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function i18nChain () {
  var first = null
  var current
  for (var i = 0; i < arguments.length; i++) {
    var handler = arguments[i]
Severity: Minor
Found in lookup/chain.js - About 1 hr to fix

Function createNode has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

function createNode (prefix, parent, translator, allowModification) {
  var node = Object.create(API)
  node.currentPrefix = prefix
  node.parent = parent
  node.translator = translator
Severity: Minor
Found in lib/createNode.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

test('Using __ on __', function (t) {
  var __ = i18n({a: 'b'}).__
  t.equals(__.__('a'), 'b')
  t.end()
})
Severity: Major
Found in test/flexAPI.js and 2 other locations - About 1 hr to fix
test/flexAPI.js on lines 17..21
test/flexAPI.js on lines 64..68

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 65.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function abs has 12 arguments (exceeds 4 allowed). Consider refactoring.
Open

  api.abs = function abs (key, namedValues, a, b, c, d, e, f, g, h, i, j) {
Severity: Major
Found in simple.js - About 1 hr to fix

Function api has 12 arguments (exceeds 4 allowed). Consider refactoring.
Open

  var api = function __ (key, namedValues, a, b, c, d, e, f, g, h, i, j) {
Severity: Major
Found in simple.js - About 1 hr to fix

Similar blocks of code found in 3 locations. Consider refactoring.
Open

test('Using translate on __', function (t) {
  var __ = i18n({a: 'b'}).__
  t.equals(__.translate('a'), 'b')
  t.end()
})
Severity: Major
Found in test/flexAPI.js and 2 other locations - About 1 hr to fix
test/flexAPI.js on lines 5..9
test/flexAPI.js on lines 17..21

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 65.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

test('Using get on __', function (t) {
  var __ = i18n({a: '%s'}).__
  t.equals(__.get('a'), '%s')
  t.end()
})
Severity: Major
Found in test/flexAPI.js and 2 other locations - About 1 hr to fix
test/flexAPI.js on lines 5..9
test/flexAPI.js on lines 64..68

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 65.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function createNode has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function createNode (prefix, parent, translator, allowModification) {
  var node = Object.create(API)
  node.currentPrefix = prefix
  node.parent = parent
  node.translator = translator
Severity: Minor
Found in lib/createNode.js - About 1 hr to fix

Function offContextChange has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

function offContextChange (type, fn) {
  if (type !== 'contextChange') {
    return
  }
  if (this.listener === fn) {
Severity: Minor
Found in lib/createNode.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function ____n has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

function ____n (node, singular, plural, count, namedValues, a, b, c, d, e, f, g, h, i, j) {
  var args
  if (j !== undefined) {
    args = [count, a, b, c, d, e, f, g, h, i, j]
  } else if (i !== undefined) {
Severity: Minor
Found in simple.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function ___ has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

function ___ (node, key, namedValues, a, b, c, d, e, f, g, h, i, j) {
  var args
  if (j !== undefined) {
    args = [a, b, c, d, e, f, g, h, i, j]
  } else if (i !== undefined) {
Severity: Minor
Found in simple.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function onContextChange has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function onContextChange (type, fn) {
  if (type !== 'contextChange' || typeof fn !== 'function' || this.listener === fn) {
    return
  }
  if (this.off === noop) {
Severity: Minor
Found in lib/createNode.js - About 1 hr to fix

Function ____n has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function ____n (node, singular, plural, count, namedValues, a, b, c, d, e, f, g, h, i, j) {
  var args
  if (j !== undefined) {
    args = [count, a, b, c, d, e, f, g, h, i, j]
  } else if (i !== undefined) {
Severity: Minor
Found in simple.js - About 1 hr to fix

Function _____n has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

function _____n (node, singular, plural, count, namedValues, args) {
Severity: Minor
Found in simple.js - About 45 mins to fix
Severity
Category
Status
Source
Language