Sign upLogin

martinheidegger/network-interfaces

View on GitHub
Star

Showing 12 of 12 total issues

Function _update has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
Open

  _update () {
    const deletedInterfaces = new Set(this._interfaces.keys())
    for (const { interfaceId, addresses } of this._collectInterfaces()) {
      deletedInterfaces.delete(interfaceId)
Severity: Minor
Found in index.js - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File index.js has 318 lines of code (exceeds 250 allowed). Consider refactoring.
Open

'use strict'
const os = require('os')
const objectHash = require('object-hash')
const deepEquals = require('fast-deep-equal')
const { hasListener } = require('has-listener')
Severity: Minor
Found in index.js - About 3 hrs to fix

    Function _process has 46 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      _process (change) {
    const { type } = change
    let networkInterface, addresses
    switch (type) {
      case ChangeType.updateInterface:
    Severity: Minor
    Found in index.js - About 1 hr to fix

      Function _update has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        _update () {
    const deletedInterfaces = new Set(this._interfaces.keys())
    for (const { interfaceId, addresses } of this._collectInterfaces()) {
      deletedInterfaces.delete(interfaceId)
      Severity: Minor
      Found in index.js - About 1 hr to fix

        Function _process has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

          _process (change) {
    const { type } = change
    let networkInterface, addresses
    switch (type) {
      case ChangeType.updateInterface:
        Severity: Minor
        Found in index.js - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              if (cause) {
        this.emit('warning', Object.assign(new Error('Couldn\'t identify the active interface.'), {
          code: 'EACTIVEERR',
          cause: cause.stack || cause
        }))
        Severity: Minor
        Found in index.js and 1 other location - About 50 mins to fix
        index.js on lines 186..191

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 51.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              if (cause) {
        this.emit('warning', Object.assign(new Error('Wasn\'t able to lookup the interfaces.'), {
          code: 'ENICTYPE',
          cause: cause.stack || cause
        }))
        Severity: Minor
        Found in index.js and 1 other location - About 50 mins to fix
        index.js on lines 171..176

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 51.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function preferInternalForLocal has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

          preferInternalForLocal (family, address) {
    const local = this.isLocalAddress(family, address)
    if (!local) {
      return address
    }
        Severity: Minor
        Found in index.js - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this function.
        Open

          if (parts[5]) return NicType.bluetooth
        Severity: Major
        Found in get-nic-types/darwin.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

            return null
          Severity: Major
          Found in get-nic-types/darwin.js - About 30 mins to fix

            Function exports has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

            module.exports = cb => {
  wmic.get_list('nic', (err, nics) => {
    if (err) return cb(err, undefined)

    cb(null, nics
            Severity: Minor
            Found in get-nic-types/win32.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function exports has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

            module.exports = cb => {
  bgbash.exec(cmd, (err, stdout) => {
    if (err) return cb(err, undefined)

    let str = stdout.toString()
            Severity: Minor
            Found in get-active/other.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language