Sign upLogin

mashirozx/mastodon

View on GitHub
Star
app/controllers/accounts_controller.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Method show has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

  def show
    respond_to do |format|
      format.html do
        expires_in 0, public: true unless user_signed_in?
Severity: Minor
Found in app/controllers/accounts_controller.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Class AccountsController has 21 methods (exceeds 20 allowed). Consider refactoring.
Open

class AccountsController < ApplicationController
  PAGE_SIZE     = 20
  PAGE_SIZE_MAX = 200

  include AccountControllerConcern
Severity: Minor
Found in app/controllers/accounts_controller.rb - About 2 hrs to fix

    Method show has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def show
    respond_to do |format|
      format.html do
        expires_in 0, public: true unless user_signed_in?
    Severity: Minor
    Found in app/controllers/accounts_controller.rb - About 1 hr to fix

      Method filtered_statuses has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def filtered_statuses
    default_statuses.tap do |statuses|
      statuses.merge!(hashtag_scope)    if tag_requested?
      statuses.merge!(only_media_scope) if media_requested?
      statuses.merge!(no_replies_scope) unless replies_requested?
      Severity: Minor
      Found in app/controllers/accounts_controller.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status