Sign upLogin

mashirozx/mastodon

View on GitHub
Star
app/lib/activitypub/activity.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Class Activity has 24 methods (exceeds 20 allowed). Consider refactoring.
Open

class ActivityPub::Activity
  include JsonLdHelper
  include Redisable
  include Lockable
Severity: Minor
Found in app/lib/activitypub/activity.rb - About 2 hrs to fix

    Method klass has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def klass
      case @json['type']
      when 'Create'
        ActivityPub::Activity::Create
      when 'Announce'
    Severity: Minor
    Found in app/lib/activitypub/activity.rb - About 1 hr to fix

      Method status_from_object has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def status_from_object
    # If the status is already known, return it
    status = status_from_uri(object_uri)

    return status unless status.nil?
      Severity: Minor
      Found in app/lib/activitypub/activity.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status