mashirozx/mastodon

View on GitHub
app/models/account.rb

Summary

Maintainability
D
2 days
Test Coverage

Class Account has 66 methods (exceeds 20 allowed). Consider refactoring.
Open

class Account < ApplicationRecord
  self.ignored_columns = %w(
    subscription_expires_at
    secret
    remote_url
Severity: Major
Found in app/models/account.rb - About 1 day to fix

    File account.rb has 453 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class Account < ApplicationRecord
      self.ignored_columns = %w(
        subscription_expires_at
        secret
        remote_url
    Severity: Minor
    Found in app/models/account.rb - About 6 hrs to fix

      Method advanced_search_for_sql_template has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def advanced_search_for_sql_template(following)
            if following
              <<-SQL.squish
                WITH first_degree AS (
                  SELECT target_account_id
      Severity: Minor
      Found in app/models/account.rb - About 1 hr to fix

        Method fields_attributes= has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

          def fields_attributes=(attributes)
            fields     = []
            old_fields = self[:fields] || []
            old_fields = [] if old_fields.is_a?(Hash)
        
        
        Severity: Minor
        Found in app/models/account.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status