Sign upLogin

maskletter/tenp

View on GitHub
Star

Showing 61 of 62 total issues

Function createInterfaceServer has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function createInterfaceServer(config, classInfo, $class, app) {
    return __awaiter(this, void 0, void 0, function () {
        var pathMap;
        var _this = this;
        return __generator(this, function (_a) {
Severity: Minor
Found in core/dist/lib/server.js - About 1 hr to fix

    Function start has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function start(){
        let options = packConfig.tenp.pm2;
        if(argv.indexOf('-i') != -1){
            options.execMode = 'cluster';
            if(isNaN(argv[argv.indexOf('-i')+1])){
    Severity: Minor
    Found in cli/lib/pm2.js - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      exports.Injector = function (name) {
    return function (target, propertyKey) {
        target[propertyKey] = {};
        target['tenp_provide_' + name] = propertyKey;
    };
      Severity: Minor
      Found in core/dist/lib/plugin/injector.plugin.js and 1 other location - About 55 mins to fix
      core/dist/lib/plugin/common.plugin.js on lines 31..36

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 54.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      exports.Global = function (name) {
    return function (target, propertyKey) {
        target[propertyKey] = {};
        target['tenp_glogal_' + name] = propertyKey;
    };
      Severity: Minor
      Found in core/dist/lib/plugin/common.plugin.js and 1 other location - About 55 mins to fix
      core/dist/lib/plugin/injector.plugin.js on lines 51..56

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 54.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function createPackage has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      async function createPackage(name){
    console.log('create init')
    let pacakge = {};
    pacakge.name = await readlinePromise(`  package name: (${name})`) || name;
    const validateresult = validate(pacakge.name);
      Severity: Minor
      Found in cli/lib/init.js - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function reportDiagnostic has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          function reportDiagnostic(diagnostic, loaderOptions, colors, compiler, merge) {
      Severity: Minor
      Found in cli/lib/dev.js - About 35 mins to fix

        Function createRouterServer has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        async function createRouterServer(config: tenp.StartInterface, routerMap: NewFunction[], app: Application){

    for(let Class of routerMap){
        const Router = (Class as any).class ? (Class as any).class : Class;
        let classInfo = dbRouterInfo[Router.prototype.$$id]
        Severity: Minor
        Found in core/lib/server.ts - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function TraversingRouter has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        function TraversingRouter(RouterList, apiTree){

    for(var i in RouterList){

        var $router = new RouterList[i];
        Severity: Minor
        Found in cli/lib/api.js - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

            public onAfter(pathConfig: tenp.PathConfig, config: tenp.StartInterface, request: tenp.Request, response: tenp.Response): any {
        if(!pathConfig.validator) return true;
        let defaultType: string = pathConfig.validatorType || ((pathConfig as any).type=='post'?'body':'query');
        let data = {};
        if(defaultType == 'all'){
        Severity: Major
        Found in core/lib/plugin/validator.plugin.ts and 3 other locations - About 30 mins to fix
        core/lib/event.ts on lines 52..65
        core/lib/plugin/interceptor.plugin.ts on lines 51..61
        core/lib/plugin/receive.plugin.ts on lines 77..85

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Avoid too many return statements within this function.
        Open

                            return [4 /*yield*/, createInterfaceServer(config, classInfo, $class, app)];
        Severity: Major
        Found in core/dist/lib/server.js - About 30 mins to fix

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

              public async onAfter(pathConfig: tenp.PathConfig, config: tenp.StartInterface, request: tenp.Request, response: tenp.Response): Promise<any> {
        let result: boolean = true;
         for(let interceptor of pathConfig.interceptor){
            const _res = await interceptor(request, response);
            if(_res == false){
          Severity: Major
          Found in core/lib/plugin/interceptor.plugin.ts and 3 other locations - About 30 mins to fix
          core/lib/event.ts on lines 52..65
          core/lib/plugin/receive.plugin.ts on lines 77..85
          core/lib/plugin/validator.plugin.ts on lines 61..71

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 45.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Avoid too many return statements within this function.
          Open

                          return [3 /*break*/, 1];
          Severity: Major
          Found in core/dist/lib/event.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                                return [3 /*break*/, 4];
            Severity: Major
            Found in core/dist/lib/event.js - About 30 mins to fix

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

                  public async onAfter(pathConfig?: tenp.PathConfig, config?: tenp.StartInterface, request?: tenp.Request, response?: tenp.Response): Promise<any> {

        if((pathConfig as any).type == 'post'){
            const method: Function = this.globalReceive ? this.globalReceive : pathConfig.receive ? pathConfig.receive : this.defaultReceive;
            const result = await method(request);
              Severity: Major
              Found in core/lib/plugin/receive.plugin.ts and 3 other locations - About 30 mins to fix
              core/lib/event.ts on lines 52..65
              core/lib/plugin/interceptor.plugin.ts on lines 51..61
              core/lib/plugin/validator.plugin.ts on lines 61..71

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 45.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

              export const AfterPluginInterfaceEvent: (pathConfig: tenp.PathConfig, config: tenp.StartInterface, request: tenp.Request, response: tenp.Response) => Promise<any> = async (pathConfig: tenp.PathConfig, config: tenp.StartInterface, request: tenp.Request, response: tenp.Response): Promise<any> => {
    
    
    for(let plugin of config.plugin){
        if((plugin as any).onAfter){
              Severity: Major
              Found in core/lib/event.ts and 3 other locations - About 30 mins to fix
              core/lib/plugin/interceptor.plugin.ts on lines 51..61
              core/lib/plugin/receive.plugin.ts on lines 77..85
              core/lib/plugin/validator.plugin.ts on lines 61..71

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 45.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Avoid too many return statements within this function.
              Open

                                  if (!classInfo.config.router) return [3 /*break*/, 7];
              Severity: Major
              Found in core/dist/lib/server.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                                    return [3 /*break*/, 1];
                Severity: Major
                Found in core/dist/lib/server.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                                      return [4 /*yield*/, createRouterServer(config, classInfo.config.router, app)];
                  Severity: Major
                  Found in core/dist/lib/server.js - About 30 mins to fix

                    Function onAfter has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public async onAfter(pathConfig?: tenp.PathConfig, config?: tenp.StartInterface, request?: tenp.Request, response?: tenp.Response): Promise<any> {

        if((pathConfig as any).type == 'post'){
            const method: Function = this.globalReceive ? this.globalReceive : pathConfig.receive ? pathConfig.receive : this.defaultReceive;
            const result = await method(request);
                    Severity: Minor
                    Found in core/lib/plugin/receive.plugin.ts - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function onRouter has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public onRouter($class: any, routerConfig: tenp.RouterConfig, parentConfig: tenp.RouterConfig): void {
        const interceptorType: string = routerConfig.interceptorType;
        if(!interceptorType || interceptorType == 'inherit' || interceptorType == 'abandon-global'){
            //Drop global interceptor, keep router interceptor
            if(interceptorType == 'abandon-global'){
                    Severity: Minor
                    Found in core/lib/plugin/interceptor.plugin.ts - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language