Sign upLogin

masschallenge/impact-api

View on GitHub
Star

Showing 54 of 58 total issues

Function __init__ has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def __init__(self,
Severity: Major
Found in web/impact/impact/minimal_email_handler.py - About 50 mins to fix

    Avoid deeply nested control flow statements.
    Open

                            if not get_user(request).has_perm(permission_code):
                            return False  # pragma: no cover
                    # some other value is in place,
                    # so we don't require permissions
        return True
    Severity: Major
    Found in web/impact/impact/permissions/dynamic_model_permissions.py - About 45 mins to fix

      Function confirmed_user_program_data has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      def confirmed_user_program_data(program_family_data):
    program_family_to_date_created = {}
    for program_family in program_family_data:
        location = program_family["location"]
        created_at = program_family["created_at"]
      Severity: Minor
      Found in web/impact/impact/v1/helpers/profile_helper.py - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _extract_user has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def _extract_user(self, request):
        user_id = request.data.get("user_id", None)
        if user_id is not None and user_id != request.user.id:
            try:
                self.target_user = User.objects.get(pk=user_id)
      Severity: Minor
      Found in web/impact/impact/v1/views/reserve_office_hour_view.py - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function get_calendar_data has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def get_calendar_data(self, counterpart_name):
        if hasattr(self, "calendar_data"):
            return self.calendar_data
        name = counterpart_name
        if self.mentor_recipient:
      Severity: Minor
      Found in web/impact/impact/v1/views/reserve_office_hour_view.py - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def __init__(self,
      Severity: Minor
      Found in web/impact/impact/v1/classes/option_analysis.py - About 35 mins to fix

        Function map_data has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        def map_data(klass, query, order, data_keys, output_keys):
        Severity: Minor
        Found in web/impact/impact/v1/views/utils.py - About 35 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              def startup_data(self):
        return map_data(StartupTeamMember,
                        Q(user=self.instance),
                        "startup_id",
                        ["startup__organization_id",
          Severity: Minor
          Found in web/impact/impact/v1/views/user_organizations_view.py and 1 other location - About 35 mins to fix
          web/impact/impact/v1/views/organization_users_view.py on lines 41..48

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 33.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              def startup_data(self):
        return map_data(StartupTeamMember,
                        Q(startup__organization=self.instance),
                        "startup__id",
                        ["user_id",
          Severity: Minor
          Found in web/impact/impact/v1/views/organization_users_view.py and 1 other location - About 35 mins to fix
          web/impact/impact/v1/views/user_organizations_view.py on lines 42..49

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 33.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Avoid too many return statements within this function.
          Open

                      return IS_CONFIRMED_MENTOR_FILTER
          Severity: Major
          Found in web/impact/impact/views/algolia_api_key_view.py - About 30 mins to fix

            Function _extract_startup has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                def _extract_startup(self, request):
        startup_id = request.data.get("startup_id", None)
        if startup_id is None:
            self.startup = None
        else:
            Severity: Minor
            Found in web/impact/impact/v1/views/reserve_office_hour_view.py - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function analysis_tally has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                def analysis_tally(self, app_id, db_value, cache, **kwargs):
        apps = kwargs.get("apps")
        if not self._app_ids_to_pf_name and apps.count() > 0:
            self.calc_app_ids_to_targets(apps)
        else:
            Severity: Minor
            Found in web/impact/impact/v1/helpers/matching_program_criterion_helper.py - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function validate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                def validate(self, attrs):
        start_date_time = None
        end_date_time = None
        if self.instance is not None:
            start_date_time = self.instance.start_date_time
            Severity: Minor
            Found in web/impact/impact/v1/serializers/office_hours_serializer.py - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function analysis_tally has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                def analysis_tally(self, app_id, db_value, cache, **kwargs):

        if not self.reads_options:
            options = self.subject.criterionoptionspec_set.values_list(
                'option', flat=True).distinct()
            Severity: Minor
            Found in web/impact/impact/v1/helpers/criterion_helper.py - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language