Sign upLogin

masschallenge/impact-api

View on GitHub
Star
web/impact/impact/permissions/dynamic_model_permissions.py

Summary

Maintainability
A
2 hrs
Test Coverage

Function has_object_permission has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    def has_object_permission(self, request, view, obj):
        model = view.kwargs.get('model', '').lower()
        related_model = view.kwargs.get('related_model', '').lower()
        model_name = model_name_case(model, related_model)
        app_label = obj._meta.app_label
Severity: Minor
Found in web/impact/impact/permissions/dynamic_model_permissions.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                        if not get_user(request).has_perm(permission_code):
                            return False  # pragma: no cover
                    # some other value is in place,
                    # so we don't require permissions
        return True
Severity: Major
Found in web/impact/impact/permissions/dynamic_model_permissions.py - About 45 mins to fix

    There are no issues that match your filters.

    Category
    Status