Sign upLogin

masschallenge/impact-api

View on GitHub
Star
web/impact/impact/v1/classes/option_analysis.py

Summary

Maintainability
B
6 hrs
Test Coverage

Function application_criteria_read_state has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def application_criteria_read_state(self, feedbacks):
        if not self.application_criteria_read_state_cache:
            ids_cache_value = {}

            db_values = feedbacks.values(
Severity: Minor
Found in web/impact/impact/v1/classes/option_analysis.py - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def __init__(self,
Severity: Minor
Found in web/impact/impact/v1/classes/option_analysis.py - About 35 mins to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        def get_criteria_fields(self, *args):
        fields = list(args)
        for criterion_helper in self.criterion_helpers.values():
            fields += criterion_helper.analysis_fields()
        return fields
    Severity: Major
    Found in web/impact/impact/v1/classes/option_analysis.py and 1 other location - About 1 hr to fix
    web/impact/impact/v1/classes/option_analysis.py on lines 224..228

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 41.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        def get_app_state_criteria_fields(self, *args):
        fields = list(args)
        for criterion_helper in self.criterion_helpers.values():
            fields += criterion_helper.app_state_analysis_fields()
        return fields
    Severity: Major
    Found in web/impact/impact/v1/classes/option_analysis.py and 1 other location - About 1 hr to fix
    web/impact/impact/v1/classes/option_analysis.py on lines 218..222

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 41.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        def get_criteria_annotate_fields(self):
        fields = {}
        for criterion_helper in self.criterion_helpers.values():
            fields.update(criterion_helper.analysis_annotate_fields())
        return fields
    Severity: Major
    Found in web/impact/impact/v1/classes/option_analysis.py and 1 other location - About 1 hr to fix
    web/impact/impact/v1/classes/option_analysis.py on lines 236..241

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 39.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        def get_app_state_criteria_annotate_fields(self):
        fields = {}
        for criterion_helper in self.criterion_helpers.values():
            fields.update(
                criterion_helper.get_app_state_criteria_annotate_fields())
    Severity: Major
    Found in web/impact/impact/v1/classes/option_analysis.py and 1 other location - About 1 hr to fix
    web/impact/impact/v1/classes/option_analysis.py on lines 230..234

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 39.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status