Sign upLogin

mateusjunges/laravel-acl

View on GitHub
Star
src/Concerns/HasPermissions.php

Summary

Maintainability
C
1 day
Test Coverage

File HasPermissions.php has 281 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace Junges\ACL\Concerns;

use Illuminate\Database\Eloquent\Builder;
Severity: Minor
Found in src/Concerns/HasPermissions.php - About 2 hrs to fix

    Method assignPermission has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function assignPermission($permissions): self
    {
        $permissions = collect(is_array($permissions) || $permissions instanceof Collection ? $permissions : func_get_args())
            ->flatten()
            ->reduce(function ($array, $permission) {
    Severity: Minor
    Found in src/Concerns/HasPermissions.php - About 1 hr to fix

      Avoid too many return statements within this method.
      Open

              return $this;
      Severity: Major
      Found in src/Concerns/HasPermissions.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                return $permissions;
        Severity: Major
        Found in src/Concerns/HasPermissions.php - About 30 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  $permissions = collect(is_array($permissions) || $permissions instanceof Collection ? $permissions : func_get_args())
            ->flatten()
            ->reduce(function ($array, $permission) {
                if (empty($permission)) {
                    return $array;
          Severity: Major
          Found in src/Concerns/HasPermissions.php and 1 other location - About 4 hrs to fix
          src/Concerns/HasGroups.php on lines 112..131

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 171.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status