Sign upLogin

mateusz-opoka/KustoWrapper-Schema-AttributeMappings

View on GitHub
Star

Showing 6 of 6 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        public static string GenerateTableCreateMergeCommand(KustoTableInfo kustoTable)
        {
            if (kustoTable == null) throw new ArgumentNullException(nameof(kustoTable));

            var columns = kustoTable.Columns.Select(BuildColumnSchema);
Severity: Major
Found in src/KustoWrapper.Schema.AttributeMappings/KustoWrapperCommandGenerator.cs and 1 other location - About 1 hr to fix
src/KustoWrapper.Schema.AttributeMappings/KustoWrapperCommandGenerator.cs on lines 12..20

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 92.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        public static string GenerateTableCreateCommand(KustoTableInfo kustoTable)
        {
            if (kustoTable == null) throw new ArgumentNullException(nameof(kustoTable));

            var columns = kustoTable.Columns.Select(BuildColumnSchema);
Severity: Major
Found in src/KustoWrapper.Schema.AttributeMappings/KustoWrapperCommandGenerator.cs and 1 other location - About 1 hr to fix
src/KustoWrapper.Schema.AttributeMappings/KustoWrapperCommandGenerator.cs on lines 22..30

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 92.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

        [Test]
        public void GenerateTableCreateCommand_OnSampleKustoTable_OnCustomTableNameWithSpecialChar_ShouldStringCommand()
        {
            var tableInfo = Fixture.SampleKustoTable;
            tableInfo.TableName = "Test-Custom-Table-Name";
Severity: Major
Found in src/KustoWrapper.Schema.AttributeMappings.Tests/KustoWrapperCommandGeneratorTests.cs and 3 other locations - About 40 mins to fix
src/KustoWrapper.Schema.AttributeMappings.Tests/KustoWrapperCommandGeneratorTests.cs on lines 28..38
src/KustoWrapper.Schema.AttributeMappings.Tests/KustoWrapperCommandGeneratorTests.cs on lines 68..78
src/KustoWrapper.Schema.AttributeMappings.Tests/KustoWrapperCommandGeneratorTests.cs on lines 80..90

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 72.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

        [Test]
        public void GenerateTableCreateCommand_OnSampleKustoTable_OnCustomTableName_ShouldStringCommand()
        {
            var tableInfo = Fixture.SampleKustoTable;
            tableInfo.TableName = "TestCustomTableName";
Severity: Major
Found in src/KustoWrapper.Schema.AttributeMappings.Tests/KustoWrapperCommandGeneratorTests.cs and 3 other locations - About 40 mins to fix
src/KustoWrapper.Schema.AttributeMappings.Tests/KustoWrapperCommandGeneratorTests.cs on lines 40..50
src/KustoWrapper.Schema.AttributeMappings.Tests/KustoWrapperCommandGeneratorTests.cs on lines 68..78
src/KustoWrapper.Schema.AttributeMappings.Tests/KustoWrapperCommandGeneratorTests.cs on lines 80..90

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 72.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

        [Test]
        public void GenerateTableCreateMergeCommand_OnSampleKustoTable_OnCustomTableNameWithSpecialChar_ShouldStringCommand()
        {
            var tableInfo = Fixture.SampleKustoTable;
            tableInfo.TableName = "Test-Custom-Table-Name";
Severity: Major
Found in src/KustoWrapper.Schema.AttributeMappings.Tests/KustoWrapperCommandGeneratorTests.cs and 3 other locations - About 40 mins to fix
src/KustoWrapper.Schema.AttributeMappings.Tests/KustoWrapperCommandGeneratorTests.cs on lines 28..38
src/KustoWrapper.Schema.AttributeMappings.Tests/KustoWrapperCommandGeneratorTests.cs on lines 40..50
src/KustoWrapper.Schema.AttributeMappings.Tests/KustoWrapperCommandGeneratorTests.cs on lines 68..78

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 72.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

        [Test]
        public void GenerateTableCreateMergeCommand_OnSampleKustoTable_OnCustomTableName_ShouldStringCommand()
        {
            var tableInfo = Fixture.SampleKustoTable;
            tableInfo.TableName = "TestCustomTableName";
Severity: Major
Found in src/KustoWrapper.Schema.AttributeMappings.Tests/KustoWrapperCommandGeneratorTests.cs and 3 other locations - About 40 mins to fix
src/KustoWrapper.Schema.AttributeMappings.Tests/KustoWrapperCommandGeneratorTests.cs on lines 28..38
src/KustoWrapper.Schema.AttributeMappings.Tests/KustoWrapperCommandGeneratorTests.cs on lines 40..50
src/KustoWrapper.Schema.AttributeMappings.Tests/KustoWrapperCommandGeneratorTests.cs on lines 80..90

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 72.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language