Sign upLogin

mateuszdw/qaror

View on GitHub
Star
app/controllers/login_controller.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method login_with_omniauth has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def login_with_omniauth
    omniauth = request.env["omniauth.auth"]
    authentication = Authentication.find_by_provider_and_uid(omniauth['provider'],omniauth['uid'])
    if authentication
      # jesli uid juz istnieje loguje odrazu
Severity: Minor
Found in app/controllers/login_controller.rb - About 1 hr to fix

    Method login_with_email_and_pass has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

      def login_with_email_and_pass
    if request.post? && params[:login] && params[:login][:email] && params[:login][:password]
        if params[:login][:email].blank? || params[:login][:password].blank?
          flash[:login_error] = t :all_fields_required
          redirect_to login_index_url
    Severity: Minor
    Found in app/controllers/login_controller.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method login_with_omniauth has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def login_with_omniauth
    omniauth = request.env["omniauth.auth"]
    authentication = Authentication.find_by_provider_and_uid(omniauth['provider'],omniauth['uid'])
    if authentication
      # jesli uid juz istnieje loguje odrazu
    Severity: Minor
    Found in app/controllers/login_controller.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status