Sign upLogin

mateuszdw/qaror

View on GitHub
Star

Showing 63 of 63 total issues

Method ako has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def ako
    # params[:k] - api key
    # params[:opt] - option / unckeck all subscribed field / uncheck question only
    # params[:opt_id] - option id
    @user = User.active.find_by_apikey!(params[:k])
Severity: Minor
Found in app/controllers/users_controller.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method login_with_omniauth has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def login_with_omniauth
    omniauth = request.env["omniauth.auth"]
    authentication = Authentication.find_by_provider_and_uid(omniauth['provider'],omniauth['uid'])
    if authentication
      # jesli uid juz istnieje loguje odrazu
Severity: Minor
Found in app/controllers/login_controller.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method log_impression has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

      def log_impression(ip,user=nil)
        unless APP_CONFIG['unique_impressions']
          set_achievement
          return
        end
Severity: Minor
Found in lib/extender/impressionable.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language