Sign upLogin

matheusmr13/app-script-mock

View on GitHub
Star

Showing 9 of 9 total issues

DriveApp has 24 functions (exceeds 20 allowed). Consider refactoring.
Open

class DriveApp {
    static _folders_: { [string]: Folder } = {};
    static _files_: { [string]: File } = {};
    static _removedFolders_: Array<Folder> = [];
    static _removedFiles_: Array<File> = [];
Severity: Minor
Found in src/DriveApp/index.js - About 2 hrs to fix

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        static getFilesByType(mimeType: String): FileIterator {
        return new FileIterator(
            Object
                .keys(DriveApp._files_)
                .map(key => DriveApp._files_[key])
    Severity: Major
    Found in src/DriveApp/index.js and 2 other locations - About 2 hrs to fix
    src/DriveApp/index.js on lines 63..70
    src/DriveApp/index.js on lines 85..92

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 83.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        static getFoldersByName(name: String): FolderIterator {
        return new FolderIterator(
            Object
                .keys(DriveApp._folders_)
                .map(key => DriveApp._folders_[key])
    Severity: Major
    Found in src/DriveApp/index.js and 2 other locations - About 2 hrs to fix
    src/DriveApp/index.js on lines 63..70
    src/DriveApp/index.js on lines 72..79

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 83.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        static getFilesByName(name: String): FileIterator {
        return new FileIterator(
            Object
                .keys(DriveApp._files_)
                .map(key => DriveApp._files_[key])
    Severity: Major
    Found in src/DriveApp/index.js and 2 other locations - About 2 hrs to fix
    src/DriveApp/index.js on lines 72..79
    src/DriveApp/index.js on lines 85..92

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 83.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        static addFile(child: File): Folder {
        DriveApp._root_.addFile(child);
        DriveApp._files_[child.getId()] = child;
        return DriveApp._root_;
    }
    Severity: Major
    Found in src/DriveApp/index.js and 1 other location - About 1 hr to fix
    src/DriveApp/index.js on lines 49..53

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 65.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        static addFolder(child: Folder): Folder {
        DriveApp._root_.addFolder(child);
        DriveApp._folders_[child.getId()] = child;
        return DriveApp._root_;
    }
    Severity: Major
    Found in src/DriveApp/index.js and 1 other location - About 1 hr to fix
    src/DriveApp/index.js on lines 43..47

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 65.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function SUM has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        SUM(params) {
        let sum = 0;
        const notNumbersParams = [];

        if (params) {
    Severity: Minor
    Found in src/SpreadsheetApp/Formulas.js - About 1 hr to fix

      Consider simplifying this complex logical expression.
      Open

              if (!row ||
            !col ||
            row <= 0 ||
            col <= 0 ||
            lines > this.matrix.length ||
      Severity: Major
      Found in src/SpreadsheetApp/Sheet.js - About 40 mins to fix

        Function processFormulas has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            processFormulas() {
        const processFormula = (cell, formulas) => {
            if (cell.getFormula() && !cell.getValue()) {
                cell.setFormula(cell.getFormula().trim());
                const parts = cell.getFormula().split('(');
        Severity: Minor
        Found in src/SpreadsheetApp/Sheet.js - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language