matheuswhite/bluebees

File `provisioner.py` has 478 lines of code (exceeds 250 allowed). Consider refactoring.
Open

from bluebees.common.client import Client
from dataclasses import dataclass
from bluebees.common.utils import order, crc8
from asyncio import wait_for
from ecdsa import NIST256p, SigningKey

Found in bluebees/client/node/provisioner.py - About 7 hrs to fix

File `config.py` has 430 lines of code (exceeds 250 allowed). Consider refactoring.
Open

from bluebees.client.node.node_data import node_name_list
from bluebees.client.application.application_data import ApplicationData, app_name_list
from bluebees.client.node.node_data import NodeData
from bluebees.client.network.network_data import NetworkData
from bluebees.common.file import file_helper

Found in bluebees/client/node/commands/config.py - About 6 hrs to fix

File `transport_layer.py` has 357 lines of code (exceeds 250 allowed). Consider refactoring.
Open

from bluebees.client.mesh_layers.network_layer import NetworkLayer
from bluebees.client.mesh_layers.mesh_context import SoftContext
from bluebees.client.network.network_data import NetworkData
from bluebees.client.application.application_data import ApplicationData
from bluebees.client.node.node_data import NodeData

Found in bluebees/client/mesh_layers/transport_layer.py - About 4 hrs to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

Found in bluebees/client/application/application.py and 1 other location - About 2 hrs to fix

Read up
Read up

bluebees/client/network/network.py on lines 0..15

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 54.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Don't Repeat Yourself on the C2 Wiki
Duplicated Code on SourceMaking
Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76

Similar blocks of code found in 2 locations. Consider refactoring.
Open

Found in bluebees/client/network/network.py and 1 other location - About 2 hrs to fix

Read up
Read up

bluebees/client/application/application.py on lines 0..15

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 54.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Don't Repeat Yourself on the C2 Wiki
Duplicated Code on SourceMaking
Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76

Function `_change_random` has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    def _change_random(self, field_value: str):
        while True:
            if re.findall(r'\\d', field_value):
                val = str(randint(0, 9))
                field_value = field_value.replace('\\d', val, 1)

Found in bluebees/common/template.py - About 1 hr to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `init` has 9 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def __init__(self, loop, device_uuid: bytes, netkey: bytes,

Found in bluebees/client/node/provisioner.py - About 1 hr to fix

Function `_obsfucate` has 9 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def _obsfucate(self, ctl: int, ttl: int, seq: int, src: bytes,

Found in bluebees/client/mesh_layers/network_layer.py - About 1 hr to fix

Function `__check_addresses` has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    def __check_addresses(self, recv_ctx: SoftContext,
                          ctx: SoftContext) -> bool:
        if address_type(recv_ctx.dst_addr) == UNICAST_ADDRESS:
            send_dst_type = address_type(ctx.dst_addr)
            if send_dst_type == UNICAST_ADDRESS:

Found in bluebees/client/mesh_layers/transport_layer.py - About 1 hr to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `find_key` has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

def find_key(obj_dict: dict, key: str):
    for k in obj_dict.keys():
        if k == key:
            return obj_dict[k]
        elif type(obj_dict[k]) != dict:

Found in bluebees/common/utils.py - About 55 mins to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `init` has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def __init__(self, name, addr, network, device_uuid, devkey, seq=0, apps=[]):

Found in bluebees/client/node/node_data.py - About 50 mins to fix

Function `init` has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def __init__(self, name, key, key_index, iv_index, apps=[], nodes=[]):

Found in bluebees/client/network/network_data.py - About 45 mins to fix

Function `run` has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

def run(baudrate, port, search_dongle):
    '''Run the main features of bluebees. This features are:
         - Dongle Communication
         - Internal Broker'''

Found in bluebees/client/core/commands/run.py - About 45 mins to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `req` has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

def req(target, opcode, parameters, r_opcode, devkey, app):

Found in bluebees/client/node/commands/req.py - About 45 mins to fix

Function `new` has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

def new(name, network, address, uuid, template):

Found in bluebees/client/node/commands/new.py - About 35 mins to fix

Function `send` has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

def send(target, opcode, parameters, devkey, app):

Found in bluebees/client/node/commands/send.py - About 35 mins to fix

Function `init` has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def __init__(self, name, key, key_index, network, nodes=[]):

Found in bluebees/client/application/application_data.py - About 35 mins to fix

Function `provisioning_device` has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

def provisioning_device(device_uuid: bytes, network: str,

Found in bluebees/client/node/commands/new.py - About 35 mins to fix

Function `aes_ccm_complete` has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def aes_ccm_complete(self, key: bytes, nonce: bytes, text: bytes, adata: bytes, mic_size=8):

Found in bluebees/common/crypto.py - About 35 mins to fix

Function `update_sequence` has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def update_sequence(self, template, field_name, custom_pattern=None):
        field_raw_value = template[field_name]

        if type(field_raw_value) != str:
            return None

Found in bluebees/common/template.py - About 35 mins to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading