matiasmenares/Nissboard

View on GitHub
dashboard/api/settings/alarm_setting.py

Summary

Maintainability
C
1 day
Test Coverage

Showing 2 of 2 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

def get(self):
alarm = Alarm.query.all()
alarm_schema = AlarmSchema(many=True)
alarm_types = AlarmType.query.all()
alarm_types_schema = AlarmTypeSchema(many=True)
Severity: Major
Found in dashboard/api/settings/alarm_setting.py and 2 other locations - About 6 hrs to fix
dashboard/api/dashboard.py on lines 11..18
dashboard/api/settings/kinek_setting.py on lines 11..18

Similar blocks of code found in 2 locations. Consider refactoring.
Open

alarm = Alarm(name=params['name'], description=params['description'], life_second=params['life_second'],alarm_type=AlarmType.query.get(params['alarm_type_id']))
Severity: Major
Found in dashboard/api/settings/alarm_setting.py and 1 other location - About 2 hrs to fix
dashboard/api/settings/channels/output.py on lines 42..42
Category
Status