Sign upLogin

matkoniecz/CartoCSSHelper

View on GitHub
Star
lib/cartocss_helper/overpass_query_generator.rb

Summary

Maintainability
C
1 day
Test Coverage

Class OverpassQueryGenerator has 25 methods (exceeds 20 allowed). Consider refactoring.
Open

  class OverpassQueryGenerator
    class NoLocationFound < StandardError
    end
    # TODO: - split into cache handling and Overpass handling
    def self.get_query_to_find_data_pair(bb, tags_a, tags_b, type_a, type_b, distance_in_meters: 20)
Severity: Minor
Found in lib/cartocss_helper/overpass_query_generator.rb - About 2 hrs to fix

    Method turn_tag_into_overpass_filter has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def self.turn_tag_into_overpass_filter(tag)
      filter_data = translate_tag_object_into_filter_data(tag)
      value = filter_data[:value]
      key = filter_data[:key]
      operator = filter_data[:operator]
    Severity: Minor
    Found in lib/cartocss_helper/overpass_query_generator.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method get_query_to_get_location_set_format has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def self.get_query_to_get_location_set_format(tags, type, latitude, longitude, range, format)
    Severity: Minor
    Found in lib/cartocss_helper/overpass_query_generator.rb - About 45 mins to fix

      Method find_data_pair has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def self.find_data_pair(tags_a, tags_b, latitude, longitude, type_a, type_b, bb_size: 0.1, distance_in_meters: 20, invalidate_cache: false)
      Severity: Minor
      Found in lib/cartocss_helper/overpass_query_generator.rb - About 45 mins to fix

        Method get_query_element_to_get_location has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def self.get_query_element_to_get_location(tags, latitude, longitude, type, range)
        Severity: Minor
        Found in lib/cartocss_helper/overpass_query_generator.rb - About 35 mins to fix

          Method get_query_to_get_location has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def self.get_query_to_get_location(tags, type, latitude, longitude, range)
          Severity: Minor
          Found in lib/cartocss_helper/overpass_query_generator.rb - About 35 mins to fix

            Method get_query_to_find_data_pair has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                def self.get_query_to_find_data_pair(bb, tags_a, tags_b, type_a, type_b, distance_in_meters: 20)
            Severity: Minor
            Found in lib/cartocss_helper/overpass_query_generator.rb - About 35 mins to fix

              Method get_elements_near_given_location has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  def self.get_elements_near_given_location(tags, type, latitude, longitude, range_in_meters, invalidate_cache: false)
              Severity: Minor
              Found in lib/cartocss_helper/overpass_query_generator.rb - About 35 mins to fix

                Method locate_element_with_given_tags_and_type has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    def self.locate_element_with_given_tags_and_type(tags, type, latitude, longitude, max_range_in_km_for_radius = 1600)
                Severity: Minor
                Found in lib/cartocss_helper/overpass_query_generator.rb - About 35 mins to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      def self.overpass_bbox_string(latitude, longitude, size)
      min_latitude = latitude - size / 2
      max_latitude = latitude + size / 2
      min_longitude = longitude - size / 2
      max_longitude = longitude + size / 2
                  Severity: Minor
                  Found in lib/cartocss_helper/overpass_query_generator.rb and 1 other location - About 45 mins to fix
                  lib/cartocss_helper/notes_downloader.rb on lines 37..43

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 40.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status