Sign upLogin

matkoniecz/CartoCSSHelper

View on GitHub
Star
lib/cartocss_helper/tag_lister.rb

Summary

Maintainability
C
1 day
Test Coverage

Method is_key_rendered_and_value_ignored has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    def is_key_rendered_and_value_ignored(key, value)
      return false if notis_rendered key, get_generic_tag_value
      [false, true].each do |on_water|
        [Configuration.get_max_z].each do |zlevel|
          ['area', 'closed_way', 'way', 'node'].each do |type|
Severity: Minor
Found in lib/cartocss_helper/tag_lister.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method how_rendered_as_composite has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    def how_rendered_as_composite(key, value, suggested_composite, zlevels = [Configuration.get_max_z]) # TODO: - note that some tags may be rendered up to X zoom level, but checking all zlevels would take too much time
      [false, true].each do |on_water|
        zlevels.each do |zlevel|
          result = how_rendered_on_zlevel_as_composite({ key => value }, 'closed_way', zlevel, on_water, suggested_composite)
          return result if result != nil
Severity: Minor
Found in lib/cartocss_helper/tag_lister.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method is_rendered_with_this_composite has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def is_rendered_with_this_composite(tags, type, provided_composite, zlevel, on_water)
Severity: Minor
Found in lib/cartocss_helper/tag_lister.rb - About 35 mins to fix

    Method is_key_rendered_and_value_ignored_set has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def is_key_rendered_and_value_ignored_set(key, value, type, zlevel, on_water)
    Severity: Minor
    Found in lib/cartocss_helper/tag_lister.rb - About 35 mins to fix

      Method how_rendered_on_zlevel_as_composite has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def how_rendered_on_zlevel_as_composite(tags, type, zlevel, on_water, suggested_composite)
      Severity: Minor
      Found in lib/cartocss_helper/tag_lister.rb - About 35 mins to fix

        Method print_render_state_of_tag has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            def print_render_state_of_tag(key, value)
      if is_rendered key, value
        @last_composite = nil
        if value == get_generic_tag_value
          puts "#{key}=#{value} - primary generic tag value"
        Severity: Minor
        Found in lib/cartocss_helper/tag_lister.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

              return false if with_composite.is_output_identical(composite_interpreted_as_area)
        Severity: Major
        Found in lib/cartocss_helper/tag_lister.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                return true
          Severity: Major
          Found in lib/cartocss_helper/tag_lister.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                  return nil
            Severity: Major
            Found in lib/cartocss_helper/tag_lister.rb - About 30 mins to fix

              Method is_rendered_with_this_composite has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  def is_rendered_with_this_composite(tags, type, provided_composite, zlevel, on_water)
      tags_with_composite = deep_clone(tags)
      composite = deep_clone(provided_composite)
      composite.each do |key, value|
        if tags_with_composite[key] != nil
              Severity: Minor
              Found in lib/cartocss_helper/tag_lister.rb - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method get_expected_state has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  def self.get_expected_state(key, value)
      CartoCSSHelper::Configuration.get_style_specific_data.list_of_documented_tags.each do |documented|
        next unless documented.key == key
        return documented.state if documented.value == value
      end
              Severity: Minor
              Found in lib/cartocss_helper/tag_lister.rb - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method get_expected_composite has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  def self.get_expected_composite(key, value)
      CartoCSSHelper::Configuration.get_style_specific_data.list_of_documented_tags.each do |documented|
        next unless documented.key == key
        return documented.composite if documented.value == value
      end
              Severity: Minor
              Found in lib/cartocss_helper/tag_lister.rb - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  def self.get_expected_composite(key, value)
      CartoCSSHelper::Configuration.get_style_specific_data.list_of_documented_tags.each do |documented|
        next unless documented.key == key
        return documented.composite if documented.value == value
      end
              Severity: Minor
              Found in lib/cartocss_helper/tag_lister.rb and 1 other location - About 20 mins to fix
              lib/cartocss_helper/tag_lister.rb on lines 35..40

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 27.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  def self.get_expected_state(key, value)
      CartoCSSHelper::Configuration.get_style_specific_data.list_of_documented_tags.each do |documented|
        next unless documented.key == key
        return documented.state if documented.value == value
      end
              Severity: Minor
              Found in lib/cartocss_helper/tag_lister.rb and 1 other location - About 20 mins to fix
              lib/cartocss_helper/tag_lister.rb on lines 43..48

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 27.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status