Sign upLogin

matteoferla/DnD-battler

View on GitHub
Star
DnD_battler/creature/_level.py

Summary

Maintainability
B
5 hrs
Test Coverage

Function parse_attacks has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    def parse_attacks(self,
                      attacks: Optional[List[Union[dict, Action, AttackRoll]]] = None,
                      **others) -> Action:
        """
        A multiattack is a curious case where a creature can do multiple attacks as a single action.
Severity: Minor
Found in DnD_battler/creature/_level.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function set_ac has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def set_ac(self,
Severity: Minor
Found in DnD_battler/creature/_level.py - About 35 mins to fix

    Function parse_attack has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def parse_attack(self, attack: Union[None, Action, dict, list]) -> Action:
        if attack is None:  # nothing to be done.
            return None
        elif isinstance(attack, Action):
            return attack  # already an action.
    Severity: Minor
    Found in DnD_battler/creature/_level.py - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

                return multi
    Severity: Major
    Found in DnD_battler/creature/_level.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                  return self.parse_attack(attacks)
      Severity: Major
      Found in DnD_battler/creature/_level.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                    return attacks[0]
        Severity: Major
        Found in DnD_battler/creature/_level.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                      return self.parse_attack(attacks)
          Severity: Major
          Found in DnD_battler/creature/_level.py - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                        return equip_standard_weapon(self, weapon_name=attack)
            Severity: Major
            Found in DnD_battler/creature/_level.py - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                          return self.parse_attacks(attacks)
              Severity: Major
              Found in DnD_battler/creature/_level.py - About 30 mins to fix

                There are no issues that match your filters.

                Category
                Status