Sign upLogin

matteoferla/DnD-battler

View on GitHub
Star
DnD_battler/creature/junk/_initialise.py

Summary

Maintainability
D
1 day
Test Coverage

Function _initialise has a Cognitive Complexity of 73 (exceeds 5 allowed). Consider refactoring.
Open

    def _initialise(self, **settings):
        """
        Preface.
        Character creation in DnD_battler is rather painful. Here due to missing it is even more complex.
        Also, creature, character and monster are used interchangably here unfortunately, which will be fixed one day.
Severity: Minor
Found in DnD_battler/creature/junk/_initialise.py - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function clean_settings has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    def clean_settings(self, dirtydex: dict) -> dict:
        """
        Sanify the settings

        :return: a cleaned dictionary
Severity: Minor
Found in DnD_battler/creature/junk/_initialise.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _initialise has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def _initialise(self, **settings):
        """
        Preface.
        Character creation in DnD_battler is rather painful. Here due to missing it is even more complex.
        Also, creature, character and monster are used interchangably here unfortunately, which will be fixed one day.
Severity: Minor
Found in DnD_battler/creature/junk/_initialise.py - About 1 hr to fix

    There are no issues that match your filters.

    Category
    Status